Please help me test out my code

Question about the task

Under discussion

For some reasons it fails but I have no idea where it might be bugging out. I tried a few use cases plus the one outlined in the task they all passed.

Read from the console the name of a file containing HTML.

Example:
Info about Leela Leela Turanga
Supergirl

The main method's first parameter is a tag name. For example, "span".
Display all tags that match the specified tag.
The order should match their order in the file, each tag on a new line.
The number of spaces, newline characters (\n), or carriage returns (\r) does not affect the result.
The file does not have a CDATA tag. Each opening tag has a separate closing tag, and there are no self-closing tags.
Tags may have nested tags.

Example output:
Leela Turanga Leela Turanga Super girl

Tag templates:
<tag>text1</tag> <tag text2>text1</tag> <tag text2>text1</tag>

text1 and text2 can be empty

Requirements:

The program must read the file name from the console (use BufferedReader).
The BufferedReader used for reading input from the console must be closed after use.
The program must read the file's contents (use FileReader).
The file input stream (FileReader) must be closed.
The program must write to the console all the tags that match the tag specified by the argument passed to the main method.

package com.codegym.task.task19.task1918; /* Introducing tags */ import java.io.BufferedReader; import java.io.FileReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.Scanner; public class Solution { public static void main(String[] args) { BufferedReader consoleReader = new BufferedReader(new InputStreamReader(System.in)); try { if (args.length == 1) { FileReader fileReader = new FileReader(consoleReader.readLine()); consoleReader.close(); StringBuilder tag = new StringBuilder(); String openigTag = '<' + args[0] ; String closingTag = "</" + args[0] + ">"; int count = 0; while (fileReader.ready()) { int c = fileReader.read(); if ((c == '\n' || c == '\r') && tag.length() > 0 && tag.charAt(tag.length() - 1) != '>') { continue; } tag.append((char)c); if (c == '>') { if (!tag.toString().contains(openigTag)) { tag.delete(0, tag.length()); continue; } count = tagCount(tag.toString(), openigTag) - tagCount(tag.toString(), closingTag); if (tag.toString().contains(closingTag) && count == 0) { System.out.println(tag.toString().substring(tag.indexOf(openigTag))); tag.delete(0, tag.length()); } } } fileReader.close(); } } catch (IOException e) { e.printStackTrace(); } } public static int tagCount(String str, String tag) { int lastIndex = 0; int count = 0; while(lastIndex != -1){ lastIndex = str.indexOf(tag, lastIndex); if(lastIndex != -1){ count ++; lastIndex += tag.length(); } } return count; } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Fadi Alsaidi

Level 34 , Carrollton, TX, USA

19 April 2020, 18:32

You need to try this more rigid example posted by a great user. Code GYM gave and easy example, as you already seen a lot of people are getting the correct output. try the below and if you are able to get the correct answer then you should be good to go. Tips: 1- make sure your starting index is the very next open tag every single time . Don't start from the last closed tag unless you use it as a starting point to find the next open tag. 2- make sure you account for nested tags

zhaoyang

Level 25 , Los Angeles, United States

3 July 2019, 00:06

I get struggled in this task for a long time. Finally, I passed it. The key is you need test with double nested tag, such as <tag> text1 <tag> text2 <tag> text3 </tag> </tag></tag>, and also print it out by order.

Tumelo Mohlala

Level 31 , Johannesburg, South Africa

16 July 2019, 04:25

thanks I'll give it a whack.

Kron1K

Level 26 , AUS, Australia

24 June 2019, 05:52

String openigTag = '<' + args[0] ;
String closingTag = "</" + args[0] + ">";

Is the opening tag meant to be closed like the closing tag? <args> ?

Tumelo Mohlala

Level 31 , Johannesburg, South Africa

26 June 2019, 04:29

Not quite because if you close it you will exclude tags with attributes. i.e <tag name="example">whatever</tag> this would be excluded.