Not passing validation

Question about the task

Resolved

When I run this, it does everything it is meant to. I get a bomb when isMine is true, the number of bombs matches the field count and the number of bombs surround the cell is correct when isMine is false. Problem is I cannot get these two things to pass validation on openTile(). I cannot see what I am missing. Help???

At this stage, we'll deal with the logic to reveal cells. Let's create a corresponding method and a variable that will store the cell state (revealed or hidden).

When revealing a cell, the method will:

- draw a mine in the cell if it contains a mine;
- display the number of mined neighbors if the cell does not contain a mine;
- mark the cell as revealed in the model;
- change the cell color.

For convenience, we suggest adding the mine symbol to a separate constant. When the a cell be revealed? Correct! When you click on it with the left mouse button. To handle this click event, the engine has a special method: onMouseLeftClick(int, int).

Let's override it in our class. It will call the method that reveals a cell.

And, of course, run the program and enjoy the results of your work.

Requirements:

The MinesweeperGame class must have a private static final String MINE field that is initialized when it is declared. For example, you can use the UTF-16 symbol for a bomb: "\uD83D\uDCA3".
The MinesweeperGame class must have a private void openTile(int x, int y) method.
The openTile(int, int) method must draw MINE if the gameObject at the passed coordinates is a mine. Use the setCellValue(int, int, String) method.
The openTile(int, int) method must draw the number of adjacent mines if the gameObject at the passed coordinates is not a mine. Use the setCellNumber(int, int, int) method.
The GameObject class must have a public boolean isOpen field.
The openTile(int, int) method should set the isOpen field on the gameField element equal to true and use the setCellColor(int, int, Color) method to draw the cell background. For example, using Color.GREEN.
The MinesweeperGame class must override the Game parent class's onMouseLeftClick(int, int) method.
The onMouseLeftClick(int, int) method must call the openTile(int, int) method.

package com.codegym.games.minesweeper; import com.codegym.engine.cell.*; import java.util.ArrayList; public class MinesweeperGame extends Game{ private static final int SIDE=9; private static final String MINE = "\uD83D\uDCA3"; private GameObject[][] gameField = new GameObject[SIDE][SIDE]; private int countMinesOnField=0; public void initialize(){ setScreenSize(SIDE,SIDE); createGame(); } private void createGame(){ for (int x=0;x<SIDE;x++){ for(int y=0;y<SIDE;y++){ boolean isMine = false; if (getRandomNumber(10)==2) { isMine = true; countMinesOnField++; } gameField[x][y] = new GameObject(y,x, isMine); setCellColor(y,x,Color.RED); } } countMineNeighbors(); } @Override public void onMouseLeftClick(int x, int y){ openTile(x,y); } private ArrayList<GameObject> getNeighbors(GameObject cell){ ArrayList<GameObject> neighbourList = new ArrayList<GameObject>(); //row above if (cell.y-1>=0){ if(cell.x-1>=0) neighbourList.add(gameField[cell.y-1][cell.x-1]); neighbourList.add(gameField[cell.y-1][cell.x]); if (cell.x+1<SIDE) neighbourList.add(gameField[cell.y-1][cell.x+1]); } //same row if (cell.x-1>=0) neighbourList.add(gameField[cell.y][cell.x-1]); if (cell.x+1<SIDE) neighbourList.add(gameField[cell.y][cell.x+1]); //row below if (cell.y+1<SIDE){ if(cell.x-1>=0) neighbourList.add(gameField[cell.y+1][cell.x-1]); neighbourList.add(gameField[cell.y+1][cell.x]); if (cell.x+1<SIDE) neighbourList.add(gameField[cell.y+1][cell.x+1]); } return neighbourList; } private void countMineNeighbors(){ for(int i=0;i<SIDE;i++){ for(int j=0;j<SIDE;j++){ if(gameField[i][j].isMine == false){ for(GameObject z:getNeighbors(gameField[i][j])){ if (z.isMine == true) gameField[i][j].countMineNeighbors++; } } } } } private void openTile(int x, int y){ if(gameField[x][y].isMine){ setCellValue(x,y, MINE); } else { setCellNumber(x,y,gameField[x][y].countMineNeighbors); } gameField[x][y].isOpen = true; setCellColor(x,y,Color.GREEN); } }

Comments (8)

Popular
New
Old

You must be signed in to leave a comment

Ailin

Level 3 , Saint Louis, France

24 January 2020, 07:32

What is

isOpen

at line 96?

GCPix Backend Developer

29 January 2020, 10:33

It is a boolean in the tile object to see if the tile has been previously checked for mines and left open because there isn't any mines surrounding it. I can't remember if I set the name or if it came with the original start point but in the instructions they refer to open tiles so if I named it it would have been based on their description.