Can anyone see what is wrong?

Question about the task

User, loser, coder and programmer

Java Core, Level 4, Lesson 8

Resolved

I am getting the correct output. But, it is not verifying Thanks in advance.

1. Enter a few strings (keys) from the keyboard [in a loop].
The following strings (keys) are allowed: "user", "loser", "coder", "programmer".
Stop reading in strings after reading in any string that does not match one of the above.

2. For each entered string:
2.1. Create the appropriate object [see Person.java], e.g. create a User object for the string "user".
2.2. Pass this object to the doWork method.

3. Write an implementation of the doWork method, which:
3.1. Calls the live() method on the passed object if person is a User.
3.2. Calls the doNothing() method if person is a Loser.
3.3. Calls the writeCode() method if person is a Coder.
3.4. Calls the enjoy() method if person is a Programmer.

Requirements:

The main method must read strings from the keyboard.
The main method should stop reading strings from the keyboard as soon as the entered string does not match one of the allowed strings ("user", "loser", "coder", "programmer").
For each correctly entered string ("user", "loser", "coder", "programmer"), call the doWork method with the appropriate Person object as the argument.
The Solution class must implement a doWork method with one Person parameter.
The doWork method should call the live() method on the passed object if it is a User.
The doWork method should call the doNothing() method on the passed object if it is a Loser.
The doWork method should call the writeCode() method on the passed object if it is a Coder.
The doWork method should call the enjoy() method on the passed object if it is a Programmer.

package com.codegym.task.task14.task1411; import java.io.BufferedReader; import java.io.InputStreamReader; /* User, loser, coder and programmer */ import java.util.*; public class Solution implements Person { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); Person person = null; String key = null; while(true) // Here's the loop for reading the keys. Item 1 { key = reader.readLine(); if(key.equals("user")) { person = new User(); doWork(person); continue; } if(key.equals("loser")) { person = new Loser(); doWork(person); continue; } if(key.equals("coder")) { person = new Coder(); doWork(person); continue; } if(key.equals("programmer")) { person = new Programmer(); doWork(person); continue; } else { reader.close(); break; } }// Call doWork } public static void doWork(Person person) { // Item 3 if(person instanceof User) { User u = (User)person; u.live(); } else if(person instanceof Loser) { Loser l = (Loser)person; l.doNothing(); } else if(person instanceof Coder) { Coder c = (Coder)person; c.writeCode(); } else if(person instanceof Programmer) { Programmer p = (Programmer)person; p.enjoy(); } } }

Comments (6)

Popular
New
Old

You must be signed in to leave a comment

Nithin

Level 35 , Hyderabad, India

17 July 2019, 16:03

User and all other classes are inner classes in Person class. so when you are using them outside of their outer class they should be called like :

if(person instanceof Person.User){
            ((Person.User) person).live();
        }

Implement like this for all instances in doWork method

Geethika medidi

Level 18 , Hyderabad, India

18 July 2019, 06:29

It doesn't verify even then.

Nithin

Level 35 , Hyderabad, India

18 July 2019, 09:09

you need to write like that for all classes. if it till doesn't verify send me your code

Geethika medidi

Level 18 , Hyderabad, India

18 July 2019, 14:12

package com.codegym.task.task14.task1411;

import java.io.BufferedReader;
import java.io.InputStreamReader;

import java.util.*;
public class Solution implements Person  {
    public static void main(String[] args) throws Exception {
        BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
        Person person = null;
        String key = null;
        while(true)
        // Here's the loop for reading the keys. Item 1
        {
            key = reader.readLine();
             if(key.equals("user"))
                {
                    person = new User();
                    doWork(person);
                    continue;
                }
                if(key.equals("loser"))
                {
                    person = new Loser();
                    doWork(person);
                    continue;
                }
                if(key.equals("coder"))
                {
                    person = new Coder();
                    doWork(person);
                    continue;
                }
                if(key.equals("programmer"))
                {
                    person = new Programmer();
                    doWork(person);
                    continue;
                }
            else
            {
                reader.close();
                break;

            }
            }// Call doWork

    }

    public static void doWork(Person person) {
       if(person instanceof Person.User)
        {
            ((Person.User)person).live();
        }
        else if(person instanceof Person.Loser)
        {
            ((Person.Loser)person).doNothing();
        }
        else if(person instanceof Person.Coder)
        {
            ((Person.Coder)person).writeCode();
        }
        else if(person instanceof Person.Programmer)
        {
            ((Person.Programmer)person).enjoy();
        }
    }
}

Nithin

Level 35 , Hyderabad, India

18 July 2019, 14:45

solution

try removing static keyword from all the methods in the person class

Geethika medidi

Level 18 , Hyderabad, India

18 July 2019, 17:53

It worked :D Thank you so much. so the method should be called on passed object (the method should be created on that instance) not on the method that is already present(that is static).Got it.