Where did I mistake.

Question about the task

Under discussion

The fifth condition require from me using FileWriter , I am using it , but It says that I commit mistake , please help me to understand what wrong in this code;

Read 2 file names from the console.
Output to the second file all characters from the first file with an even ordinal number (ordinal numbers start with 1).

Example first file:
text in file
Output in the second file:
eti ie

Close the IO streams.

Requirements:

The program should read file names from the console (use BufferedReader).
The BufferedReader used for reading input from the console must be closed after use.
The program must read the first file's contents (use the FileReader constructor with a String parameter).
The file input stream (FileReader) must be closed.
The program must write to the second file all chars from the first file with an even ordinal number (use FileWriter).
The file output stream (FileWriter) must be closed.

package com.codegym.task.task19.task1906; /* Even characters */ import java.io.*; import java.util.ArrayList; public class Solution { public static void main(String[] args) throws IOException{ BufferedReader br = new BufferedReader(new InputStreamReader(System.in)); String fileName = br.readLine(); String fileName2 = br.readLine(); br.close(); getOdd(fileName , fileName2); System.out.println("DONE"); } //C:\Users\samsung\Desktop\f1.txt //C:\Users\samsung\Desktop\f2.txt public static void getOdd(String path1 , String path2) throws IOException { FileReader fr = new FileReader(path1); FileWriter fw = new FileWriter(path2); BufferedReader br = new BufferedReader(fr); String line; while((line = br.readLine()) != null) { for (int i = 1 ; i < line.length() ; i = i + 2) { fw.write(line.charAt(i)); } } fr.close(); fw.close(); } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

9 October 2019, 14:13

Your problem most likely is that if there are multiple lines then your code only outputs the odd ordinal characters starting at each new line. However that may not be the correct order in continuation. For example: Inputs: abcdef ghijklm your output: bdfhjl correct output: bdfgikm <-- remember that new line characters are valid characters You should either read one character at a time and use a counter to output each odd read, or read everything in first and then output each odd character. BufferedReader with readline() will not work in this because it removes new line characters.

Premachandran

Level 35 , Ernakulam, India

9 October 2019, 06:51

it seems your code will write odd numbered bytes not even numbered bytes try i = 2 with i = i + 2

Ulan Mukanbetov

Level 26 , Bishkek, Kyrgyzstan

24 September 2019, 04:36

the result is same but i think validator doesnt want use bufferedreader. Try this: 1) set int counter from 1 2) in while cycle check counter for even f.e. if (index % 2 == 0) write the byte via filewriter 3) dont forget increment the counter to 1 index++ I think this will work for you! Good luck!