CodeGym/Help with Java Tasks/Please Help

Level 16

Lahore

22.09.2018
1889views
16comments

Please Help

Question about the task

Under discussion

The code seems to be working fine, but the verification system is not accepting the solution: Don't change the main - I haven't The program must return the correct result - It does :\

package com.codegym.task.task11.task1123; public class Solution { public static void main(String[] args) throws Exception { int[] data = new int[]{1, 2, 3, 5, -2, -8, 0, 77, 5, 5}; Pair<Integer, Integer> result = getMinimumAndMaximum(data); System.out.println("The minimum is " + result.x); System.out.println("The maximum is " + result.y); } public static Pair<Integer, Integer> getMinimumAndMaximum(int[] array) { if (array == null || array.length == 0) { return new Pair<Integer, Integer>(null, null); } //write your code here for(int i = 0 ; i < array.length-1 ; i++) { int k = 0; for(int j = i ; j < array.length-1 ; j++) { if(array[k] > array[k+1]) { int temp = array[k]; array[k] = array[k+1]; array[k+1] = temp; } k++; } } int min = array[0]; int max = array[array.length-1]; return new Pair<Integer, Integer>(min, max); } public static class Pair<X, Y> { public X x; public Y y; public Pair(X x, Y y) { this.x = x; this.y = y; } } }

Comments (16)

Popular
New
Old

You must be signed in to leave a comment

Александр Култыгин

Level 22 , Moscow, Russian Federation

20 February 2019, 08:48

Arrays.sort нельзя использовать по условию, так как порядок массива будет изменен. Решается через переменные: int min = Integer.MAX_VALUE; int max = Integer.MIN_VALUE; for (int i = 0; i < array.length; i++) { if (min>array[i]){ min=array[i]; } if (max<array[i]){ max=array[i]; } } return new Pair<Integer, Integer>(min, max);

Roman

Level 41

3 October 2018, 06:16

It will be fixed soon, thanks.

Ricardo Olivarria

Level 16

24 September 2018, 18:48

Also getting the same failed tests, code is working fine.

package com.codegym.task.task11.task1123;

public class Solution {
    public static void main(String[] args) throws Exception {
        int[] data = new int[]{1, 2, 3, 5, -2, -8, 0, 77, 5, 5};

        Pair<Integer, Integer> result = getMinimumAndMaximum(data);

        System.out.println("The minimum is " + result.x);
        System.out.println("The maximum is " + result.y);
    }

    public static Pair<Integer, Integer> getMinimumAndMaximum(int[] array) {
        if (array == null || array.length == 0) {
            return new Pair<Integer, Integer>(null, null);
        }
        int max = array[0], min = array[0];

        for(int x = 1; x < array.length ; x++){
            if(array[x] > max){
                max = array[x];
            }
            if(array[x] < min){
                min = array[x];
            }
        }

        return new Pair<Integer, Integer>(min, max);
    }


    public static class Pair<X, Y> {
        public X x;
        public Y y;

        public Pair(X x, Y y) {
            this.x = x;
            this.y = y;
        }
    }
}

Ankush Rajput

Level 25 , Bhopal, India

25 September 2018, 04:47

Try a built-in sort method to sort array. It worked for me.

Ankush Rajput

Level 25 , Bhopal, India

22 September 2018, 12:37

Code seems fine.. no idea why its not verifying. Try a built-in sort method to sort array. It worked for me.

Learner

Level 16 , India

26 September 2018, 10:32

None works: built-in or your own logic. There is something wrong with it.

Khurram

Level 16 , Lahore, Pakistan

26 September 2018, 11:00

same here, also, the core level useful links are under-construction and the nerd break videos don't work. Guessing, maybe the Core level is under development or undergoing changes.

Ankush Rajput

Level 25 , Bhopal, India

26 September 2018, 12:55

I got it verified, so there isn't something wrong with it. I used Arrays.sort() method or Collections.sort() (both of them are built-in in java) don't exactly remember as code which I submitted isn't saved on the server anymore. But my solution passed. But yes, codegym should be a bit lenient with verifying. It happened to me a lot of times that my program was working fine but not accepting, then I had to tweak a bit to match tests of codegym (which nobody knows about).

Learner

Level 16 , India

27 September 2018, 05:41

Here is my code:

package com.codegym.task.task11.task1123;
import java.util.Arrays;

public class Solution {
    public static void main(String[] args) throws Exception {
        int[] data = new int[]{1, 2, 3, 5, -2, -8, 0, 77, 5, 5};

        Pair<Integer, Integer> result = getMinimumAndMaximum(data);

        System.out.println("The minimum is " + result.x);
        System.out.println("The maximum is " + result.y);
    }

    public static Pair<Integer, Integer> getMinimumAndMaximum(int[] array) {
        if (array == null || array.length == 0) {
            return new Pair<Integer, Integer>(null, null);
        }

        //write your code here
        Arrays.sort(array);

        return new Pair<Integer, Integer>(array[0], array[array.length-1]);
    }


    public static class Pair<X, Y> {
        public X x;
        public Y y;

        public Pair(X x, Y y) {
            this.x = x;
            this.y = y;
        }
    }
}

Ankush Rajput

Level 25 , Bhopal, India

27 September 2018, 06:14

This should work. I guess, i was just lucky to get it passed. Maybe you can try Collections.sort() for one last time. Maybe it has something to do with how their tests are implemented.

Learner

Level 16 , India

27 September 2018, 06:37

Wouldn't that mean converting given array of integers into a list, then use Collections and then convert it back to array? That is very lengthy.

Ankush Rajput

Level 25 , Bhopal, India

27 September 2018, 06:50

You can convert to List in one line using List list = Arrays.asList(array). Then use Collections.sort() and then pass list.get(0) and list.get(list.size()-1) without converting back to array.

Learner

Level 16 , India

27 September 2018, 09:07

Nope, doesn't verify.

Ankush Rajput

Level 25 , Bhopal, India

28 September 2018, 14:07

Hey, one more thing just came to my mind while answering another question. Try casting array[0] and array[array.length-1] to Integer. It is the same thing but maybe verification test might be checking for Integer wrapper and not primitive int.

return new Pair<Integer, Integer>((Integer)array[0], (Integer)array[array.length-1]);

If it passes let us know.

Learner

Level 16 , India

29 September 2018, 05:33

No, still doesn't verify.

Shreyas Joshi

Level 16 , Mumbai, India

31 March 2019, 05:14

public class Solution { public static void main(String[] args) throws Exception { int[] data = new int[]{1, 2, 3, 5, -2, -8, 0, 77, 5, 5}; Pair<Integer, Integer> result = getMinimumAndMaximum(data); System.out.println("The minimum is " + result.x); System.out.println("The maximum is " + result.y); } public static Pair<Integer, Integer> getMinimumAndMaximum(int[] array) { if (array == null || array.length == 0) { return new Pair<Integer, Integer>(null, null); } //write your code here int max = array[0], min = array[0]; for(int x = 1; x < array.length ; x++){ if(array[x] > max){ max = array[x]; } if(array[x] < min){ min = array[x]; } } return new Pair<Integer, Integer>(min, max); } public static class Pair<X, Y> { public X x; public Y y; public Pair(X x, Y y) { this.x = x; this.y = y; } } }