Correct output, but not satisfying conditions

Well ok, Conditions == The end Create a list of strings. Enter strings from the keyboard and add them to the list. Enter strings from the keyboard until the user enters "end". The string "end" is ignored. Display the strings on the screen, each on a new line. Requirements: 1. Declare a string list variable and immediately initialize it. 2. Read strings from the keyboard and add them to a list until the user enters "end". 3. Do not add "end" to the list. 4. Display the list, each value on a new line. 5. Use a for loop. Accepted Solution == package com.codegym.task.task07.task0722; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.ArrayList; /* The end */ public class Solution { public static void main(String[] args) throws IOException { BufferedReader buff = new BufferedReader(new InputStreamReader(System.in)); //write your code here // int max = Integer.MAX_VALUE; ArrayList<String> list = new ArrayList<> (); for (int x = 0; x < 5000; x++) { list.add(buff.readLine()); if (list.get(x).equals("end")) { list.remove("end"); break; } } for (int x = 0; x < list.size(); x++) { System.out.println(list.get(x)); } } }

for (int x = 0; x < 5000; x++) { this line should be: while (true){ That makes an infinite loop, which inside you have a solution to break it when the user enters "end". My only suggestion would be to do this instead:

while (true) {
   String entry = buff.readLine()
   if(entry.equals("end")) break; // ends loop immediately if "end" is entered
   list.add(entry);
   // now you don't have to remove "end"
}

Thanks a lot I saw the solution with the while loop also somewhere else, but just wondered why my code was accepted with the changes I made and it was not working with MAX_VALUE. For clarification = This 3 lines were not accepted = int max = Integer.MAX_VALUE; for (int x = 0; x < max; x++) { for (int x = 0; x < max; x++) { Changing them to // int max = Integer.MAX_VALUE; for (int x = 0; x < 5000; x++) { for (int x = 0; x < list.size(); x++) { satisfied all conditions. although the Output in both codes was the same, so it might be just a conditions thing as both codes seemed legit. At least I could not find another issue. Btw thanks for being pro-active and helping us newbies with the tasks. We appreciate it. Kris

The last for loop definitely needs to run with list.size() as the requirement. If you used another number, the likely hood of it actually being the size of the list is very small. Lets say, for example, you use max like you did. If the size of the list is anything less than max, then once the loop reaches an index higher than the amount of elements contained within, an IndexOutOfBoundsException will be thrown when list.get(x) is reached, and (if left unhandled) will crash the program. Also, if the number you use is smaller than the amount of elements in list then the program won't output all the contained data.

And its my pleasure to help. I still learn a lot from helping others, especially practice using the debugging tools in IntelliJ.