Could anyone help me?

Question about the task

Replacing numbers

Java Core, Level 9, Lesson 11

Archived

My solution seems good to me, but not for codegym. what's the problem?

1. In a static block, initialize map with (number, word) pairs from 0 to 12 inclusive.
For example, (0, "zero"), (1, "one"), (2, "two")
2. Read the file name from the console, and then read the contents of the file.
3. Use map to replace all of the numbers with words.
4. Display the result.
5. Close the streams.

Example file data:
This costs 1 dollar, but this is 12. The variable is called file1. 110 is a number.

Example console output:
This costs one dollar, but this is twelve. The variable is called file1. 110 is a number.

Requirements:

The Solution class must have a public static Map<Integer, String> field called words that is initialized immediately.
The program must read the file name from the console (use BufferedReader).
The BufferedReader used for reading input from the console must be closed after use.
The program must read the file's contents (use FileReader).
The file input stream (FileReader) must be closed.
The program should write all of the lines from the file to the console, but any numbers must be replaced with the corresponding words in map.
The Solution class must have a static block that adds thirteen pairs to map.

package com.codegym.task.task19.task1924; import java.util.HashMap; import java.util.Map; import java.io.*; import java.util.*; /* Replacing numbers */ public class Solution { public static Map<Integer, String> map = new HashMap<Integer, String>(); static{ map.put(0, "zero"); map.put(1, "one"); map.put(2, "two"); map.put(3, "three"); map.put(4, "four"); map.put(5, "five"); map.put(6, "six"); map.put(7, "seven"); map.put(8, "eight"); map.put(9, "nine"); map.put(10, "ten"); map.put(11, "eleven"); map.put(12, "twelve"); } public static void main(String[] args) throws IOException { BufferedReader bf = new BufferedReader(new InputStreamReader(System.in)); String fileName = bf.readLine(); bf.close(); FileReader fileReader = new FileReader(fileName); BufferedReader reader = new BufferedReader(fileReader); String line; while (reader.ready()) { line = reader.readLine(); String[] s = line.split(" "); for (int i = 0; i < s.length; i++) { for (Map.Entry<Integer, String> pair : map.entrySet()) { Integer key = pair.getKey(); String value = pair.getValue(); if (s[i].equals(key.toString())) { line = line.replaceFirst(key.toString(), value); } if (s[i].charAt(s[i].length() - 1) == '.' && (s[i].length() == 2 || s[i].length() == 3)) { String removedDot = s[i].replace(".", " "); if(removedDot.trim().equals(key.toString())) { line = line.replace(key.toString(), value); } } } if (i == s.length - 1) System.out.println(line); } } fileReader.close(); reader.close(); } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Ian De Bie Full Stack Developer

21 October 2020, 22:31

i like to keep it simple...

public static void main(String[] args) throws IOException {
    String file;
    try (BufferedReader buff = new BufferedReader(new InputStreamReader(System.in))) {
        file = buff.readLine();
    }
    try (BufferedReader input = new BufferedReader(new FileReader(file))) {
        while (input.ready()) {
            String[] arr = input.readLine().split("\\s+");
            for (int i = 0; i < arr.length; ++i)
                try {
                    int num = Integer.parseInt(arr[i]);
                    if (map.containsKey(num)) arr[i] = map.get(num);
                } catch (NumberFormatException ignore) { }
            System.out.println(String.join(" ", arr));
        }
    }
}

Andrei

Level 41

22 February 2021, 10:11

But how do you separate 12. from 12 ? I see no function to take into consideration this scenario? Separating punctuation marks from numbers.

Wei Cui

Level 39 , Newark, United States

7 March 2020, 23:44

using StringBuilder could easier solve this problem. replace from line 44.

while (br.ready()) {
            StringBuilder sb = new StringBuilder();
            String[] arr = br.readLine().split(" ");
            for(String s : arr) {
                String punctuation = s.replaceAll("[a-zA-Z0-9]", ""); //take out all punctuation from string;
                String word = s.replaceAll("[^a-zA-Z0-9]", ""); // replace all punctuation
                if (isDigitValue(word)) {      // if word is digit, compare if it in the maps , replace it if it in the map
                    if (map.containsKey(Integer.parseInt(word)))
                        word = map.get(Integer.parseInt(word));
                }
                sb.append(word).append(punctuation).append(" "); // put all parts comeback.

            }
            System.out.println(sb.toString().trim()); //convert stringbuilder to string and print
        }
        br.close();
    }


    public static boolean isDigitValue (String s) {  //identify if word is numeric
        if (s == null) {
            return false;
        }
        try {

            int i = Integer.parseInt(s);
        }catch (NumberFormatException e) {
            return false;
        }
        return true;
    }

Guadalupe Gagnon

Level 37 , Tampa, United States

29 January 2020, 20:41

This program does a lot of unnecessary work. For each line it splits it by space, which is great, but then it iterates through the entire map comparing values. When a value is found that matches, it doesn't break the loop and continues iterating through. This can very easily be replaced like this:

String[] s = line.split(" ");

for (int i = 0; i < s.length; i++) {
   if(map.contains(s[i]){ // checks if it is contained
      s = map.get(s[i])  // replaces the number
}

That should make your algorithm much simpler and easier to debug. The other issue is that sentences have more than just "." periods. For example, I tested with a sentence like this "test sentence 12, test", and the code did not pick up the 12 before the comma.

Guadalupe Gagnon

Level 37 , Tampa, United States

29 January 2020, 20:54

It also changed made this change, I haven't figured out why: "Practice is the 120." to "Practice is the one20."