Why is not ok?

Question about the task

Minesweeper (Part 5/16)

Games, Level 0, Lesson 0

Under discussion

I don't get it. Why last condition is not okay?

Minesweeper is aptly named. The player has to deal with mines, though maybe it would be best for the player to stay far away from them :)

Let's add these mines to the game. To do this, we'll adapt the GameObject class to account for the fact that a cell can be a mine (by adding the isMine flag).

Don't create a new constructor: editing the existing constructor will suffice.

Additionally, when creating the cells, add code that generates mines with a probability of 10%. The easiest way is to use the Game class's getRandomNumber(int n) method, which returns a random number from 0 to n-1 inclusive. Therefore, the probability of generating a certain number is 1/n.

And don't forget to count the number of generated mines in the MinesweeperGame class.

Once you've done all that, run the program and check that nothing is broken :)

Requirements:

The GameObject class must have a public boolean isMine field.
The GameObject class must have one constructor with (int, int, boolean) parameters that are used to initialize the x, y, and isMine fields, in that order.
There must be a private int countMinesOnField variable in the MinesweeperGame class.
When cells are created in the createGame() method, you should randomly determine whether each cell will have a mine. Use the Game class's getRandomNumber(int) method with the argument 10.
After the createGame() method is executed, the countMinesOnField variable should be assigned the value of the number of mines in the field.

package com.codegym.games.minesweeper; import com.codegym.engine.cell.*; import javafx.geometry.Side; public class MinesweeperGame extends Game{ private GameObject[][] gameField = new GameObject[SIDE][SIDE]; private static final int SIDE = 9; int mineCounter = 0; private int countMinesOnField; public void initialize(){ setScreenSize(9,9); createGame(); } private void createGame() { this.countMinesOnField = mineCounter; for (int i = 0; i < SIDE; i++) { for (int j = 0; j < SIDE; j++) { int n = getRandomNumber(10); if (n == 9) { ++mineCounter; gameField[i][j] = new GameObject(j, i, true); setCellColor(j, i, Color.GREEN); } else { gameField[i][j] = new GameObject(j, i, false); setCellColor(j, i, Color.GREEN); } } } //System.out.println(mineCounter); } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

17 February 2020, 05:37

Because countMinesOnField is never anything other than 0. Once createGame() method should set that variable to the correct value.

Dorel

Level 2 , Satu Mare, Romania

18 February 2020, 03:31

Oh thanks a lot!