it works but fails and i just don't know wh - java help on CodeGym

Why is this failing please, i'm sorry if it has been answered before , i've tried looking but the codes vary so much and mine works so there must be something stupid i've missed. Thank you in advance the help on this site has definitely got me this far!

package com.codegym.task.task07.task0716;

import java.util.ArrayList;

/*
R or L

*/

public class Solution {
    public static void main(String[] args) throws Exception {
        boolean isTrue = false;
        ArrayList<String> list = new ArrayList<String>();
        list.add("rose"); //0
        list.add("lyre"); //2
        list.add("love"); //1


        list = fix(list);

        for (String s : list)
        {
            System.out.println(s);
        }
    }

      public static ArrayList<String> fix(ArrayList<String> list) {
        // write your code here
          ArrayList<String> listCopy = new ArrayList<String>();
          listCopy.addAll(list);
       for(int i = 0 ;i<list.size(); i++ )
       {
           if (listCopy.get(i).contains("l") && !(listCopy.get(i).contains("r"))){
               listCopy.add(listCopy.get(i));
           }

       }

       for (int j = 0; j<listCopy.size(); j++)
       {
           if(listCopy.get(j).contains("r") && !(listCopy.get(j).contains("l")))
               listCopy.remove(listCopy.get(j));
       }
          list.clear();
          list.addAll(listCopy);

        return list;
    }
}

public class Solution { public static void main(String[] args) throws Exception { boolean isTrue = false; ArrayList<String> list = new ArrayList<String>(); list.add("rose"); //0 list.add("love"); //1 list.add("lyre"); //2 list.add("rose"); list.add("measure"); list.add("wade"); list.add("bark"); list = fix(list); for (String s : list) { System.out.println(s); } } public static ArrayList<String> fix(ArrayList<String> list) { // write your code here ArrayList<String> listCopy = new ArrayList<String>(); for (int j = 0; j<list.size(); j++) { if(list.get(j).contains("r") && (list.get(j).contains("l"))) listCopy.add(list.get(j)); } for(int i = 0 ;i<list.size(); i++ ) { if (list.get(i).contains("l") && !(list.get(i).contains("r"))){ listCopy.add(list.get(i)); } } for(int i = 0 ;i<list.size(); i++ ) { if (list.get(i).contains("l") && !(list.get(i).contains("r"))){ listCopy.add(list.get(i)); } } return listCopy; } }

for (String s:list) { boolean ar=false,//here to check weather the string contain l bl=false; // here to check weather the string contain l if(s.contains("r")) ar=true; if (s.contains("l")) bl=true; // System.out.println(a); //System.out.println(b); if(ar&&bl)//if string contains both l and r then add list1.add(s); else if(bl) // if contains 'l' then double the string { list1.add(s); list1.add(s); } else if(!ar&&!bl)//if string does not contain l or r then simply add list1.add(s); } return list1; }

Comments (6)

Popular
New
Old

You must be signed in to leave a comment

Ashish RajAnand

Level 13 , Bhilai , India

6 May 2020, 04:21

1-when you already copy all String to copylist then you again add into copylist 2-task said that 2.1. remove all words containing the letter "r" from the list 2.2. duplicate all words containing the letter "l". 2.3. if a word contains both "r" and "l", then leave it unchanged. 2.4. don't do anything to other words. first implement 2.3 then 2.1 or 2.2 and which word not contain l or r then remain in the list my suggestion is create a empty _list add string which are checked through the list you populate . .

Steve Bennett

Level 18 , Stoneleigh

6 May 2020, 10:12

took your advice and still failing .

6 May 2020, 10:33

your second and third loop were same. don't make silly mistake bro . 1-in loop second you must duplicate all words containing the letter "l".

listCopy.add(list.get(i));
listCopy.add(list.get(i));

in 3 loop you must

if (list.get(i).contains("l") && !(list.get(i).contains("r")))

change the to

if (!list.get(i).contains("l") && !(list.get(i).contains("r")))

6 May 2020, 10:35

after created the empty loop this way solved

6 May 2020, 14:53

thank you Raj! You know when you've looked at something for too long and it all merges into one.

6 May 2020, 14:57

I did that to clone, i just wanted to solve it at this point didn't care how it looked

it works but fails and i just don't know why!