is my Casting the problem Line 29??

Question about the task

Resolved

Hello everyone, I cant quite make out what my issue is. Ive looked at some of the other questions raised about this problem. I still cant quite make it out. Your assistance is greatly appreciated. Mike

The first parameter of the main method is a file name.
Display the ratio of the number of spaces to the number of all characters. For example, 10.45.
1. Count all the characters (n1).
2. Count the spaces (n2).
3. Display n2/n1*100, rounding to 2 decimal places.
4. Close the streams.

Requirements:

You don't need to read anything from the console.
Create a stream to read from the file passed as the first argument of the main method.
Calculate and display the ratio of the spaces to all characters in the file.
The displayed value must be rounded to 2 decimal places.
The stream used to read the file must be closed.

package com.codegym.task.task18.task1817; /* Spaces */ import java.io.FileInputStream; import java.io.IOException; public class Solution { public static void main(String[] args) throws IOException { String fileName = args[0]; FileInputStream inStream = new FileInputStream(fileName); int n1 = 0; int n2 = 0; while(inStream.available() > 0){ int data = inStream.read(); if (data == 32) n2++; else n1++; } inStream.close(); double result = (double) (n2/n1)*100; System.out.println(Math.round(result*100.0)/100.0); } }

Comments (6)

Popular
New
Old

You must be signed in to leave a comment

Michael Brimage

Level 19 , Washington D.C., United States

21 May 2020, 20:11

Thanks Guadalupe, but I am still failing validation

Guadalupe Gagnon

Level 37 , Tampa, United States

21 May 2020, 20:12

see my updated response

Guadalupe Gagnon

Level 37 , Tampa, United States

21 May 2020, 19:57

solution

Two problems I see with this code: #1 line 29 is dividing integers. This is going to truncate any remainder before being converted to a double. If you had 3 and 2 as values then the result would be 1 where it should be 1.5. #2 space is still a character and should be included in the n1 count. For example say that a file had this: a bc d e The count for n1 would be 8 while the count for n2 would be 3. The correct ratio output would should be 37.5,

Michael Brimage

Level 19 , Washington D.C., United States

21 May 2020, 20:16

#1) okay, so I cast n1 and n2 to doubles then divide. this should correct the problem; #2) already fixed as described above. Ill give this a shot

Michael Brimage

Level 19 , Washington D.C., United States

21 May 2020, 20:18

It worked!!! thanks Lupe!!!!

Guadalupe Gagnon

Level 37 , Tampa, United States

21 May 2020, 20:21

useful

for reference, you only need to cast one to a double. When you divide a double by an int, the compiler will automatically cast the int to a double to successfully complete the operation. This would work:

double result = (double) n2 / n1 * 100;