What's wrong with CollisionObject.isCollision?

Question about the task

Sokoban (part 4)

Java Collections, Level 10, Lesson 15

Under discussion

What's wrong with CollisionObject.isCollision? I have changed the return condition to:

tiX == gameObject.getX() && tiY == gameObject.getY()

, and tried the permutation of the +/- with the direction...

We already have a shared GameObject class. It's time to create classes for specific types of game objects.
4.1. Some game objects can move (player and boxes) and some can't (walls and storage locations).
4.1.1. Add the Movable interface to the model package.
4.1.2. The Movable interface must have a void move(int x, int y) method.
4.2. Add a Direction enum to the model package. It must have the following values:
LEFT, RIGHT, UP, and DOWN. This type will be used to describe the direction of an object's movement.
4.3. The "storage location" objects don't support collision detection (the player and boxes can freely move over them). As for other objects, they must not pass through one another, i.e. they should collide. For example, a box can't be pushed through a wall.
4.3.1. Add an abstract CollisionObject class to the model package.
3.4.2. The CollisionObject class must inherit GameObject.
4.3.3. Add the following to the CollisionObject class:
4.3.3.1. A constructor that accepts int x and int y arguments.
4.3.3.2. A boolean isCollision(GameObject gameObject, Direction direction) method.
This method should return true if the current object will collide with the gameObject parameter after moving a distance of BOARD_CELL_SIZE in the direction specified by the direction parameter. Otherwise, it should return false. If (x, y) coordinates match, you have a collision.

Requirements:

Add a Movable interface to the model package.
The Movable interface must declare a void move(int x, int y) method.
Add a Direction enum to the model package. It must have the following values: LEFT, RIGHT, UP, and DOWN.
Add an abstract CollisionObject class to the model package.
The CollisionObject class must inherit GameObject.
Add a CollisionObject class constructor that accepts int x and int y arguments.
Add a boolean isCollision(GameObject gameObject, Direction direction) method to the CollisionObject class. It must implement the behavior described in the task conditions.

package com.codegym.task.task34.task3410.controller; import com.codegym.task.task34.task3410.model.Model; import com.codegym.task.task34.task3410.view.View; public class Controller { private Model model; private View view; public Controller() { this.view = new View(this); this.model = new Model(); view.init(); } public static void main(String[] args) { new Controller(); } }

Comments (1)

Popular
New
Old

You must be signed in to leave a comment

JianQiu Hwang

Level 35 , Washington

13 June 2020, 02:54

Finally I pass the test -- I remove the

import static com.codegym.task.task34.task3410.model.Model.BOARD_CELL_SIZE;

and use `Model.BOARD_CELL_SIZE` directly.