not sure why last condition fails, everything works fine

Question about the task

Resolved

Use the keyboard to enter a positive number. Determine the number of even digits and odd digits in the entered number.
If a number is divisible by 2 without a remainder (i.e. the remainder is zero), then it is even.
And we'll increase the even digit counter (static variable even) by 1.
Otherwise, the number is odd, so we'll increase the odd digit counter (static variable odd).
Display the following message: "Even: a Odd: b", where a is the number of even digits and b is the number of odd digits.

Example for 4445:
Even: 3 Odd: 1

Requirements:

The program must read data from the keyboard.
The main method should calculate how many even digits are in the entered number and then write this number to the variable even.
The main method should calculate how many odd digits are in the entered number and then write this number to the variable odd.
The program should display text on the screen.
The displayed text must match the task conditions.

package com.codegym.task.task06.task0606; import java.io.*; /* Even and odd digits */ public class Solution { public static int even; public static int odd; public static void main(String[] args) throws IOException { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int x = Integer.parseInt(reader.readLine()); while (x>1){ if ((x%2)>0){ odd++; x = x/10; } else{ even++; x = x/10; } } System.out.println("Even: " + even + " Odd: " + odd); } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Gellert Varga

Level 23 , Szekesfehervar, Hungary

2 June 2020, 23:15

solution

If the input is 148, then output is: Even: 2 Odd: 0 Line 19: When the loop would run for third time - for purpose to check the third digit (this is the '1'!) - then this happens: while (x>1) // but now the 'x' is equal to 1! So, it is false, and it will not run anymore, and this third digit will not be checked. So, the 'odd' = 0. ((This is the default initializing value of the 'odd', from Line 13.))

Mike McKenna

Level 25 , Wilmington, United States

2 June 2020, 22:14

Hi my line 17 is . int parsedNumber = Integer.parseInt(reader.readLine()); my line 19 -21 while(parsedNumber 1 = 0){ if ((parsedNumber %10) %2 ==0){ as Seb noted u need to check for positive and negative input . hope i helped

Seb

Level 41 , Crefeld, Germany

2 June 2020, 20:46

Check your program for a negative input as well as an input of the number 1. Both cases need to work correctly too.