Still can't get this to pass!

Question about the task

Build a WHERE query

Java Multithreading, Level 2, Lesson 9

Under discussion

I'm sure my returned string meets the requirements - is there a 'special' case I haven't thought of?

public static String getQuery(Map<String, String> params) {

        StringBuilder sb = new StringBuilder();
        Formatter fm = new Formatter(sb);

        Iterator<Map.Entry<String, String>> iterator = map.entrySet().iterator();
        while (iterator.hasNext()) {
            Map.Entry<String, String> entry = iterator.next();
            if (entry.getValue() == null || entry.getKey() == null) { continue; }
            else {
                fm.format("%s = '%s'", entry.getKey(), entry.getValue());
                sb.append(" and ");
            }
        }
        if (sb.length() > 6) {
            sb.delete(sb.length() - 5, sb.length() - 1);
            return sb.toString();
        }
        else return "";

    }

Build part of a WHERE query using StringBuilder.
If a parameter is null, then it shouldn't be included in the query.

Example:

{name=Johnson, country=United States, city=Los Angeles, age=null}

Result:

name = 'Johnson' and country = 'United States' and city = 'Los Angeles'

Requirements:

The getQuery method must have one Map parameter.
The getQuery method must return a String.
The getQuery method must be static.
The getQuery method must return a string built according to the rules specified in the task conditions.

package com.codegym.task.task22.task2208; import java.util.*; /* Build a WHERE query */ public class Solution { public static HashMap<String, String> map = new HashMap<>(); static { map.put(null, "Chris"); map.put(null, "Spain"); map.put("city", null); map.put(null, "29"); } public static void main(String[] args) { System.out.println(getQuery(map)); } public static String getQuery(Map<String, String> params) { if (params.values().stream().allMatch(Objects::isNull)) return ""; int counter = 0; StringBuilder sb = new StringBuilder(); Formatter fm = new Formatter(sb); Iterator<Map.Entry<String, String>> iterator = map.entrySet().iterator(); while (iterator.hasNext()) { Map.Entry<String, String> entry = iterator.next(); if (entry.getValue() == null || entry.getKey() == null) { continue; } else { fm.format("%s = '%s'", entry.getKey(), entry.getValue()); sb.append(" and "); counter++; } } if (sb.length() > 6) { sb.delete(sb.length() - 5, sb.length() - 1); return sb.toString(); } else return ""; } }

Comments (1)

Popular
New
Old

You must be signed in to leave a comment

dnlklnhfr

Level 30 , Karlsruhe, Germany

5 July 2020, 11:59

If your question is still up to date: your returned String has an additional space at the end. Generally I would suggest using a StringJoiner instead of StringBuilder for such concatenation tasks. That saves a lot of quirky problems with trailing spaces and other unwanted stuff.