Display the longest string

Question about the task

Archived

In the output window it shows "Grandmother" which is the longest string. I'm not sure why it's not passing the final two verifications. Your help is appreciated.

1. Initialize the list of strings.
2. Read 5 strings from the keyboard and add them to this list.
3. Using a loop, find the longest string in the list.
4. Display the string. If there is more than one, display each on a new line.

Requirements:

In the main method, initialize the Solution class's existing strings field to a new ArrayList<>.
The program should read 5 strings from the keyboard and write them to the list of strings.
The program should display the longest string.
If several strings qualify as the longest, then you need to display each of them on a new line.

package com.codegym.task.task07.task0708; import java.io.BufferedReader; import java.io.InputStreamReader; import java.util.ArrayList; import java.util.List; /* Longest string */ public class Solution { private static List<String> strings; public static void main(String[] args) throws Exception { //write your code here strings = new ArrayList<String>(); BufferedReader read = new BufferedReader(new InputStreamReader(System.in)); for(int i = 1; i <=5; i++){ String text = read.readLine(); strings.add(text); } int longestString = 0; String longestListString = null; for (int i = 1; i < strings.size()-1; i++) { int size = strings.get(i).length(); if (size > longestString){ longestString = size; longestListString = strings.get(i); } } System.out.println(longestListString); } }

Comments (6)

Popular
New
Old

You must be signed in to leave a comment

Thomas

Level 41 , Bayreuth, Germany

26 June 2020, 15:58

In your solution you can only have one longest string. Requirements ask to print all longest strings if there are more. So you should determin the size of the longest string(s). Then loop again through the list and if the size of the lists element is the same as of the longest string the print it. And remove the -1 in line 28 ;)

Maxine Hammett

Level 19 , San Diego, United States

26 June 2020, 16:04

I fixed the loop but I'm not sure how to make the final comparison. If there is more than one longest length.

int longestString = 0;
String longestListString = null;

for (int i = 0; i < strings.size(); i++) {
    int size = strings.get(i).length();
    if (size > longestString){
        longestString = size;
        longestListString = strings.get(i);
    }
}


System.out.println(longestListString);

Thomas

Level 41 , Bayreuth, Germany

26 June 2020, 16:09

that would work...

for (int i = 0; i < strings.size(); i++) {
    int size = strings.get(i).length();
    if (size > longestString){
        longestString = size;
    }
}

for (int i = 0; i < strings.size(); i++) {
    if (strings.get(i).length() == longestString){
        System.out.println(strings.get(i));
    }
}

Thomas

Level 41 , Bayreuth, Germany

26 June 2020, 16:11

or a little bit more compact:

strings = new ArrayList<>();
int longestString = 0;

BufferedReader read = new BufferedReader(new InputStreamReader(System.in));
for (int i = 0; i < 5; i++){
    strings.add(read.readLine());
    if (strings.get(i).length() > longestString)
        longestString = strings.get(i).length();
}

for (int i = 0; i < strings.size(); i++) {
    if (strings.get(i).length() == longestString){
        System.out.println(strings.get(i));
    }
}

Maxine Hammett

Level 19 , San Diego, United States

26 June 2020, 16:12

Thank you

Gellert Varga

Level 23 , Szekesfehervar, Hungary

26 June 2020, 15:49

Line 28. int i = 1, -- but why 1? The first item in a list is the index zero.