The output is correct but not satisfies 3 and 4 condition

Question about the task

Shortest or longest

Java Syntax, Level 7, Lesson 6

Resolved

please help me in solving it.

1. Create a list of strings.
2. Add 10 strings from the keyboard.
3. Find out which string occurs earlier in the list: the shortest or the longest.
If several strings are shortest or longest, then consider the very first such string encountered.
4. Display the string described in Step 3. One string should be displayed.

Requirements:

Declare a string list variable and immediately initialize it.
The program should read 10 strings from the keyboard and add them to the list.
The program should display the shortest string if it comes before the longest.
The program should display the longest string if it comes before the shortest.

package com.codegym.task.task07.task0712; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.*; /* Shortest or longest */ public class Solution { public static void main(String[] args) throws Exception { ArrayList<String> strings = new ArrayList<String>() ; Scanner in = new Scanner(System.in); int m=0,n=0; for(int i=0;i<10;i++){ String s = in.nextLine(); strings.add(s); } int max=strings.get(0).length(),min=strings.get(0).length(); for(int i =0;i<10;i++) { if(strings.get(i).length()>=max) max=strings.get(i).length(); } for(int i =0;i<10;i++) { if(strings.get(i).length()<=min) min=strings.get(i).length(); } for(int i =0;i<10;i++) { if(strings.get(i).length()==max) m=i; break;} for(int i =0;i<10;i++) { if(strings.get(i).length()==min) n=i; break;} int r =( m<n) ? m : n ; System.out.println(strings.get(r)); } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Riya

Level 15 , Indore, India

16 July 2020, 16:58

thanks curly braces mistake was the right one .

Sela

Level 20 , Poland

16 July 2020, 16:09

agree. lack of curly braces is the culprit - there are two statements after if clause. body of if statement must be embraced with curly braces.

hu-zza Java Developer at NIX

16 July 2020, 15:08

Yes, this code will print the first word in every situation. The problem is some misplaced / missing curly braces:

for( ....... )
{
    if( ..... )
        statement;
        break;
}

This code will run only once. In this case, the break is the part of the loop.

for( ....... )
{
    if( ..... )
    {
        statement;
        break;
    }
}

This one will run until the condition of the if statement becomes true. Hint: Indentation helps a lot. ;-)

Guadalupe Gagnon

Level 37 , Tampa, United States

16 July 2020, 14:08

This code seems to output the first word in the list and not the first word that is the shortest or longest in the list as per the task conditions.