Displays right answer but doesn't pass last two verifications

Level 37 , Tampa, United States

5 August 2020, 14:13

It looks like you have the task requirements mixed up. Use this template:

public static void main(String[] args) throws Exception {
   // #1 Read a number N from the keyboard
   // #2 check that the number N is greater than 0
   // if N is greater than 0 then
   {
      // #3 read N numbers
      while(/*This should loop N times*/){
         // read a number from the keyboard
      }
      // #4 Determine which number from step 3 is the greatest and
      // output that number to the screen
   }
  // if N is less than or equal to 0 then skip steps #3 and #4
}

Level 41 , Gdansk, Poland

5 August 2020, 15:56

WHILE loop should end in line 12. Otherwise we will need an array or a list of numbers. I think - too complicated for this task.

Level 19 , San Diego, United States

5 August 2020, 16:05

Hi I think I've folowed your notes correctly but it outputs the wrong number (19) instead of (71). Can you please take a look and tell me where i've gone wrong?

public class Solution {
    public static void main(String[] args) throws Exception {
        // #1 Read a number N from the keyboard
        BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
        int maximum = Integer.MIN_VALUE; // minimum of int type
        int N = Integer.parseInt(reader.readLine());

        // #2 check that the number N is greater than 0
        try {
            if (N > 0) {
                // #3 read N number
                while (N > 0) {
                    // read a number from the keyboard
                    int A = Integer.parseInt(reader.readLine());
                    // #4 Determine which number from step 3 is the greatest and
                    if (N > A) {
                        maximum = N;
                    } else {
                        maximum = A;
                    }
                    N--;
                }
                // output that number to the screen
                System.out.println(maximum);
            } else if (N <= 0) {}
        } catch (NumberFormatException e) {}
    }
}

Level 37 , Tampa, United States

5 August 2020, 16:11

You are close, but lines 16-20 are incorrect. N should not be used here. You only need to compare A to maximum and set maximum to A if it is the greater. Also line 25 can just be the closing bracket:

// get rid of unnecessary code:
} /*else if (N <= 0) {}*/

Level 37 , Tampa, United States

5 August 2020, 16:13

@Misui It will be the individual programmer who decides the best way to solve. My tip is meant as a guideline to hopefully give Maxine a clearer picture of what is being asked in the task.

Level 19 , San Diego, United States

5 August 2020, 16:18

Thank you it works!

Level 37 , Tampa, United States

5 August 2020, 16:43

=D Yay!

Level 41 , Gdansk, Poland

4 August 2020, 21:53

1. Read one number (from keyboard). Name it N (or what else) 2. If the number N > 0 then read N numbers. 3. Display maximum of these numbers (beside N). 4. Numbers may be negative.

Level 19 , San Diego, United States

5 August 2020, 07:59

it's still not passing the last two verification tasks. I've added the notes from your response into the code. Please let me know where I'm going wrong.

public class Solution {
    public static void main(String[] args) throws Exception {
        BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
        int maximum = 0;

        try {
            while (true) {
                //1. Read one number (from keyboard). Name it N (or what else)
                int N = Integer.parseInt(reader.readLine());
                //2. If the number N > 0 then read N numbers.
                if(N > maximum){
                    maximum = N;

                }else if(N <= 0){
                //4. Numbers may be negative.
                //The program should not display anything if N is less than or equal to 0
                }
            }
        }
        catch (NumberFormatException e) {

        }
        //3. Display maximum of these numbers (beside N).
        System.out.println(maximum);
    }
}

Level 41 , Gdansk, Poland

5 August 2020, 11:28

Remove WHILE loop. Not needed. Let's suppose you enter 3 as variable N. Check if N > 0. Then you have to read from keyboard 3 numbers. Each of them you have to compare witch variable "maximum". Numbers may be negative, so "maximum = 0" is not good choice.

Level 41 , Gdansk, Poland

5 August 2020, 12:22

Some concrete help:

public class Solution {
    public static void main(String[] args) throws Exception {
        BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
        int maximum = Integer.MIN_VALUE; // minimum of int type

        int N = Integer.parseInt(reader.readLine()); // count of numbers from which we'll choose max

        if (N > 0) {
           for (...) {
               int a = Integer.parseInt(reader.readLine());
               // here determine "maximum"
           }
        System.out.println(maximum);
      }
    }
}

Level 19 , San Diego, United States

5 August 2020, 14:01

I'm a little confused about this "Then you have to read from keyboard 3 numbers. Each of them you have to compare witch variable "maximum". I thought we were reading keyboard input until the end. Are you saying I get the first number N, and use it in a for loop to get the maximum number?