what is a wrong?

Question about the task

Shortest or longest

Java Syntax, Level 7, Lesson 6

Under discussion

please check my code

1. Create a list of strings.
2. Add 10 strings from the keyboard.
3. Find out which string occurs earlier in the list: the shortest or the longest.
If several strings are shortest or longest, then consider the very first such string encountered.
4. Display the string described in Step 3. One string should be displayed.

Requirements:

Declare a string list variable and immediately initialize it.
The program should read 10 strings from the keyboard and add them to the list.
The program should display the shortest string if it comes before the longest.
The program should display the longest string if it comes before the shortest.

package com.codegym.task.task07.task0712; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.*; /* Shortest or longest */ public class Solution { public static void main(String[] args) throws Exception { //write your code here ArrayList<String> list= new ArrayList<String>(); ArrayList<String> listS= new ArrayList<String>(); ArrayList<String> listL= new ArrayList<String>(); Scanner sc= new Scanner(System.in); for(int i=0;i<10; i++){ list.add(sc.nextLine()); // System.out.println(list.get(i)); } // System.out.println(list); int longest=list.get(0).length(); for(int i=0; i<list.size(); i++){ if(list.get(i).length()>=longest){ longest=list.get(i).length(); } }// System.out.println(longest); int Shortest=list.get(0).length(); for(int i=0; i<list.size(); i++){ if(list.get(i).length()<=Shortest){ Shortest=list.get(i).length(); } } //System.out.println(Shortest); for(int i=0; i<list.size(); i++){ if(list.get(i).length()==longest){ listL.add(list.get(i)); // System.out.println(listL); } } for(int i=0; i<list.size(); i++){ if(list.get(i).length()==Shortest){ listS.add(list.get(i)); // System.out.println(listS); } } if(listS.size()>listL.size()){ for(int i=0; i<listS.size(); i++){ // System.out.println(listS.get(i)); if(listS.get(0).length()==Shortest){ System.out.println(listS.get(0)); } break; } }else{ for(int i=0; i<listL.size(); i++){ // System.out.println(listL.get(i)); if(listL.get(0).length()==longest){ System.out.println(listL.get(0)); } break; } } } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Artem

Level 0

26 August 2020, 09:20

why not?

int max = 0;
int min = 0;
String line = "";
for(int i=0;i<10; i++){
    line = sc.nextLine();
    max = Math.max(max, line.length());
    min = Math.min(min, line.length());
    list.add(line);
}

int min = Collections.min(list);
int max = Collections.max(list);

Michael

Level 10 , Dresden, Germany

26 August 2020, 09:07

Your code seems to be a bit complicated to me. ;-) Please delete the 2 array lists 'listS' / 'ListL' which you use for the comparison operations. Instead just find the longest/shortest string and assign the index in one operation. This makes life much easier:

for (int i = 0; i < 10; i++) {
            if (list.get(i).length() > defaultLong) {
                defaultLong = list.get(i).length();
                indexLong = i;
            }
        }

        for (int j = 0; j < 10; j++) {
            if (list.get(j).length() < defaultShort) {
                defaultShort = list.get(j).length();
                indexShort = j;
            }
        }

This diagram will explain the logic and the flow of the code:

dhanush

Level 30 , Chennai, India

12 August 2020, 10:58

Actually i have tried your code in my computer it's displaying the largest number or the smallest number not the earlier longest or shortest, you are so complicating the task try to solve with less number of codes. I can't find actually where the problem is, i think the problem starts from 30 itself in the if statement you are printing all the element which is short or which is large. Try using if... else and you don't want to split the shortest and largest String in different list, after iterating the list and check if list.length>long || list.length<short check the list is equals to short || long, then add the list String to list.S or list.L Using for each loop display the result.

Mr.Murdston

Level 1 , Ankleshwar, India

12 August 2020, 10:28

where is your code ?2