Please help :)

Question about the task

Resolved

If in the first place I enter the shortest string before the longest, It's working :) If in the first place I enter the longest string before the shortest. It's working.

1. Create a list of strings.
2. Add 10 strings from the keyboard.
3. Find out which string occurs earlier in the list: the shortest or the longest.
If several strings are shortest or longest, then consider the very first such string encountered.
4. Display the string described in Step 3. One string should be displayed.

Requirements:

Declare a string list variable and immediately initialize it.
The program should read 10 strings from the keyboard and add them to the list.
The program should display the shortest string if it comes before the longest.
The program should display the longest string if it comes before the shortest.

package com.codegym.task.task07.task0712; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.ArrayList; /* Shortest or longest */ public class Solution { public static void main(String[] args) throws Exception { //write your code here ArrayList<String> list = new ArrayList<String>(); BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int shortest = 0; int longest = 0; for(int i = 0; i < 10; i++){ String s = reader.readLine(); list.add(s); if(i == 0) { shortest = s.length(); longest = s.length(); } else { if(longest < s.length()); longest = s.length(); if (shortest > s.length()); shortest = s.length(); } } for(int i = 0; i < 10; i++){ String s = list.get(i); if(s.length() == shortest) System.out.println(s); else System.out.println(s); break; } } }

Comments (8)

Popular
New
Old

You must be signed in to leave a comment

Hashirama

Level 26 , Port-Harcourt, Nigeria

16 January 2019, 15:30

How about you do it my way: simple and effortless. Get two strings, call them longest and shortest and asign the first string on the list array to them. Get two int variables; call them max and min and assign 0 to them. Use a loop and test if the shortest string is actually the shortest in the list array. If it isn't, then assign the shortest to it and also assign the very index number where you got the shortest to min. Do the same for the longest After that. Test between the min and max. If min is lesser, then print the string at index min from the array list else print the string at index max If want me to attach the code just Holla!!

Joe M

Level 47 , Owings Mills, United States

15 November 2020, 20:32

fantastic explanantion. explains but doesn't write the code. Thank you Hashirama.

hacks patel

Level 20 , Ahmedabad, India

21 December 2018, 10:53

useful

for(int i = 0 ; i < list.size() ; i++) { if(a == list.get(i).length() || b == list.get(i).length()) { System.out.println(list.get(i)); break; } } //use this logic

Guadalupe Gagnon

Level 37 , Tampa, United States

4 December 2018, 18:28

First you have semi colons (;) after the if statements in your first for loop, where the spacing seems messed up. Remove these: if(longest < s.length()); <------- if (shortest > s.length()); <------ The second error seems to be in the second for loop. Your program checks to see if the current index has the shortest, which it will print, or the else statement prints the current index, then the break exits the for loop and the program ends. In essence it just prints the first string in the list every time. You are close, you need to check to see if the value at index i is the shortest OR the longest, and print it. try this instead: for(int i = 0; i < 10; i++){ String s = list.get(i); if(s.length() == shortest || s.length() == longest) { System.out.println(s); break; } }

Laurap5

Level 9 , Vilnius, Lithuania

4 December 2018, 18:02

I don't know how to write this block: 4) if the shortest index is < longest index, print the shortest string 5) if the longest index is < shortest index, print the longest string :( not able to figure out :( tried many ways, but still doesn't work.

Michael Martin

Level 19 , Arlington, United States

4 December 2018, 18:29

After you read the strings, then find the index of the shortest string. Do you have that?

int shortest = Integer.MAX_VALUE;
int shortestIndex = 0;
for (int i = 0; i < list.size(); i++) {
   if (list(i).length < shortest)
      shortestIndex = i;
}

After this loop, you will have the index of the shortest string in the ArrayList. Then do the same thing for the longest string.

Dusernajder

Level 20 , Budapest, Hungary

25 September 2019, 16:28

The problem with this code is shortest value stays the same, after you set shortestIndex value you also have to save list.get(i).length to shortest

if (list(i).length < shortest){
      shortestIndex = i;
      shortest = list.get(i).length();
}

Michael Martin

Level 19 , Arlington, United States

4 December 2018, 16:39

Don't do everything together in one large if/else block. Break it up into different sections. 1) Read 10 strings and put into the list 2) Find the index of the shortest string 3) Find the index of the longest string 4) if the shortest index is < longest index, print the shortest string 5) if the longest index is < shortest index, print the longest string You don't need to combine everything (reading, testing, updating the shortest/longest) all at the same time.