Hey help me, I need help🙋🏻‍♂️

Question about the task

Sorting three numbers

Java Syntax, Level 4, Lesson 6

Under discussion

What's the error

package com.codegym.task.task04.task0420; /* Sorting three numbers */ import java.io.*; import java.util.Scanner; public class Solution { public static void main(String[] args) throws Exception { Scanner s = new Scanner(System.in); int a = s.nextInt(); int b = s.nextInt(); int c = s.nextInt(); if(a>=b && b>=c) System.out.println(a+" "+b+" "+c); if(b>=a && a>=c) System.out.println(b+" "+a+" "+c); if(c>=a && a>=b) System.out.println(c+" "+a+" "+b); if(c>=b && b>=a) System.out.println(c+" "+b+" "+a); if(a>=c && c>=b) System.out.println(a+" "+c+" "+b); if(b>=c && c>=a) System.out.println(b+" "+c+" "+a); //write your code here } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

sourav bamotra

Level 20 , jammu, India

25 August 2020, 10:41

buddy! understand the code properly you have written. it will work fine if all the three numbers are unique, but what if two or all input numbers are same. example: input : 3 2 3 output: 3 3 2 3 3 2 why so...... o_O because if you watch properly, there are two if statements that satisy the same condition if there are two equal numbers in the input. lets take example In your code : if(c>=a&& a>=b) if(a>=c&& c>=b) both of this statements satisfies the condition. and for input(3,2,3) it will give((3,3,2)*2times). just use if-else statement in this case in order to break each if statement. if the condition is met.....boom there is no further need to go on. in case all the numbers are equal just add another if - else statement for that as well.

anna

Level 15

25 August 2020, 07:55

It seems that if all the numbers are equal, all your if statements are matched. Only one statment should include the all equal case. and others should look more like: if (a>=b&&b>c) if (a>b&&b>=c). But there is a shorter way to solve this! Check out for java Math class, you can solve it with less if statements using Math.max( , ) and Math min( , ) methods.

Mnemonic

Level 9 , london, United Kingdom

24 August 2020, 08:45

Have a look at this approach and see if it makes sense: int tempMax = Math.max(num1, num2); int max = Math.max(tempMax, num3); int tempMin = Math.min(num1, num2); int min = Math.min(tempMin, num3);

Mateusz

Level 29 , Poland

24 August 2020, 07:08

If you have a problem like this, try to run your program many times with different input and you'll eventually find the problem :) What will your program display when all the numbers are equal? It will display them 6 times! And it should be just one :)