Last 3 conditions are not OK

Question about the task

MovieFactory

Java Core, Level 4, Lesson 8

Under discussion

Who can help? Something wrong is with loop "while" ?

Read from the console to extend the functionality by analogy:
1. Figure out what the program does.
2. All classes must be inside the Solution class.
3. Add Cartoon and Thriller classes.
4. Understand how we get a SoapOpera object using the key "soapOpera".

Following the pattern used to obtain a SoapOpera object:
5. Add to MovieFactory.getMovie the ability to get a Cartoon object using the key "cartoon".
6. Add to MovieFactory.getMovie the ability to get a Thriller object using the key "thriller".
7. Read several keys (strings) from the console.
7.1. Stop reading in strings as soon as a string is entered that does not match one of the following: "cartoon", "thriller", "soapOpera".
8. Create a Movie movie variable, and for each entered string (key):
8.1. Get an object using MovieFactory.getMovie and assign it to the variable movie.
8.2. Display the result of calling movie.getClass().getSimpleName().

Requirements:

The Cartoon and Thriller classes must be static and be located inside the Solution class.
The MovieFactory.getMovie method must return a Cartoon object if "cartoon" is passed as an argument.
The MovieFactory.getMovie method must return a Thriller object if "thriller" is passed as an argument.
The main method must read strings from the keyboard.
The main method should stop reading strings from the keyboard if an invalid string is entered (i.e. something other than "cartoon", "thriller", or "soapOpera").
For each string entered (including the invalid string), you must call the MovieFactory.getMovie method.
For each valid string entered, you need to display the simple name (movie.getClass().getSimpleName()) of the object types returned by the MovieFactory.getMovie method.

package com.codegym.task.task14.task1414; import java.util.Scanner; /* MovieFactory */ public class Solution { public static void main(String[] args) throws Exception { Scanner scanner = new Scanner(System.in); String movieFilm = null; Movie movie = null; while(true) { movieFilm = scanner.nextLine(); movie = MovieFactory.getMovie(movieFilm); if (movieFilm.equals("cartoon") || movieFilm.equals("thriller") || movieFilm.equals("soapOpera")) { System.out.println(movie.getClass().getSimpleName()); } break; } } // Read several keys (strings) from the console. Item 7 /* 8. Create a variable movie in the Movie class, and for each entered string (key): 8.1. Get an object using MovieFactory.getMovie and assign it to the variable movie. 8.2. Display the result of calling movie.getClass().getSimpleName(). */ static class MovieFactory { static Movie getMovie(String key) { Movie movie = null; // Create a SoapOpera object for the key "soapOpera" if ("soapOpera".equals(key)) { movie = new SoapOpera(); } if ("thriller".equals(key)) { movie = new Thriller(); } if ("cartoon".equals(key)) { movie = new Cartoon(); } //write your code here. Items 5, 6 return movie; } } static abstract class Movie { } static class SoapOpera extends Movie { } static class Thriller extends Movie { } static class Cartoon extends Movie { } // Write your classes here. Item 3 }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

27 August 2020, 18:10

useful

Line 23 is reached every loop cycle. This means that it breaks every time at loop one. This code would work the same exact way:

//while(true) {
   movieFilm = scanner.nextLine();
   movie = MovieFactory.getMovie(movieFilm);

   if (movieFilm.equals("cartoon") || movieFilm.equals("thriller") || movieFilm.equals("soapOpera")) {
      System.out.println(movie.getClass().getSimpleName());
   }
//break;
//}

You will need to fix this so the loop continues running as long as the conditions are met.

Marek Pasierbek Working at Nexus Polska

28 August 2020, 07:01

It was very helpful. New day, new think and do solution with You. Thanks

AmirMasoud Java Developer

1 February 2022, 06:57

But if the entry is wrong we again read the input and that's not what we want the code should be like this

while(true) {
   movieFilm = scanner.nextLine();
   movie = MovieFactory.getMovie(movieFilm);

   if (movieFilm.equals("cartoon") || movieFilm.equals("thriller") || movieFilm.equals("soapOpera")) {
      System.out.println(movie.getClass().getSimpleName());
   }else
       break;
}

Guadalupe Gagnon

Level 37 , Tampa, United States

2 February 2022, 14:27

That code would not pass either because line 5 would result in a null pointer exception if the input was not exactly one of the three accepted inputs to return a valid movie.