task08.task0814 - Greater than 10? You're not a good fit for us

Question about the task

Greater than 10? You're not a good fit for us

Resolved

task08.task0814 - Greater than 10? You're not a good fit for us When I run it has removed elements > 10. But not according to codegym vaerify?

package com.codegym.task.task08.task0814; import java.util.HashSet; import java.util.Set; /* Greater than 10? You're not a good fit for us */ public class Solution { public static HashSet<Integer> createSet() { // write your code here Set<Integer> set = new HashSet<Integer>(); for (int i=0; i< 20; i++){ set.add(i); } return (HashSet)set; } public static HashSet<Integer> removeAllNumbersGreaterThan10(HashSet<Integer> set) { // write your code here for(int i= 0; i< 20; i++){ if (i>10 && set.contains(i)){ set.remove(i); } } return set; } public static void main(String[] args) { removeAllNumbersGreaterThan10(createSet()); } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Jyothi

Level 20 , United States

12 December 2018, 01:27

Thank you. Cloned and removed from the set not being iterated. It worked.

Jyothi

Level 20 , United States

11 December 2018, 20:54

Thx. rectified that... ---- still failing this condition. I cant see where this limitation is... Be sure that the removeAllNumbersGreaterThan10 method works with sets of any size package com.codegym.task.task08.task0814; import java.util.HashSet; import java.util.Set; /* Greater than 10? You're not a good fit for us */ public class Solution { public static HashSet<Integer> createSet() { // write your code here Set<Integer> set = new HashSet<Integer>(); for (int i=0; i< 20; i++){ set.add(i); } return (HashSet)set; } public static HashSet<Integer> removeAllNumbersGreaterThan10(HashSet<Integer> set) { // write your code here for (int num : set) { if (num > 10){ set.remove(num); } } return set; } public static void main(String[] args) { //removeAllNumbersGreaterThan10(createSet()); } }

Guadalupe Gagnon

Level 37 , Tampa, United States

11 December 2018, 21:15

Bad idea to use loop on a set that you are removing objects from. Every time that you remove an object, everything inside shifts around and the loop count is thrown off. Try this: Without changing the code that you have, create a new Hashset<Integer> (name) that is an exact copy of the set that is passed through. Change the code in the for each loop to remove the object from the new set. Then return the new set. See below:

public static HashSet<Integer> removeAllNumbersGreaterThan10(HashSet<Integer> set) {
    Hashset<Integer> newSet = [copy of set]
    //^create a copy of set, google how to do this
    for (int num : set)
    {
        if (num > 10){
            newSet.remove(num);  // < remove items from the new set
        }
    }
    return newSet;   //< return the new set
}

Multivac

Level 13 , Lima, Perú

19 January 2019, 17:39

You could also use an Iterator: if you modificate(add or remove an element) a collection while traversing it at the same time, you will get a ConcurrentModificationException. This is the useful link from a previous lesson.

Michael Martin

Level 19 , Arlington, United States

11 December 2018, 19:55

The verifier doesn't always use the numbers that you do. What if the set contains the number 22? Your removeAllNumbersGreaterThan100() method will not remove it.