I'm not sure what is wrong

Question about the task

Resolved

By my logic this should print out all the family. I've read a few of the other comments and I suppose there is nothing wrong in my code. But validation says otherwise

1. Create a Human class with String name, boolean sex, int age, and ArrayList<Human> children fields.
2. Create and populate objects so that we end up with: two grandfathers, two grandmothers, one father, one mother, and three children.
3. Display all the Human objects (Hint: use the Human class's toString() method).

Requirements:

The program should display text on the screen.
The Human class must have four fields.
The Human class must have one method.
The Solution class must have one method.
The program should create objects and fill them with data to get two grandfathers, two grandmothers, one father, one mother, and three children. Then it should display all the Human objects on the screen.

package com.codegym.task.task08.task0824; /* Make a family */ import java.util.ArrayList; public class Solution { public static void main(String[] args) { ArrayList<Human> childrens = new ArrayList<>(); Human child1 = new Human("Walter", 21, true, childrens); Human child2 = new Human("Paula", 14, false, childrens); Human child3 = new Human("Jose", 19, true, childrens); ArrayList<Human> children = new ArrayList<>(); children.add(child1); children.add(child2); children.add(child3); Human mother = new Human("Andrea", 47, false, children); Human father = new Human("Pedro", 50, true, children); ArrayList<Human> maternal = new ArrayList<>(); maternal.add(mother); Human granma = new Human("Gloria", 69, false, maternal); Human granpa = new Human("Mario", 73, true, maternal); ArrayList<Human> paternal = new ArrayList<>(); paternal.add(father); Human grandPa1 = new Human("Salomon", 76, true, paternal); Human grandMa1 = new Human("Teresa", 70, false, paternal); System.out.println("paternal Granfather is: " + grandPa1.toString()); System.out.println("paternal Granmother is: " + grandMa1.toString()); System.out.println("Maternal Granfather is: " + granma.toString()); System.out.println("Maternal GranMother is: " + granpa.toString()); System.out.println("Father is: " + father); System.out.println("Mother is : " + mother); System.out.println("Children are: " + child1.toString()); System.out.println("Children are: " + child2.toString()); System.out.println("Children are: " + child3.toString()); } public static class Human { String name = "Unknown"; int age = 0; boolean sex = false; ArrayList<Human> children = new ArrayList<>(); public Human(){ } public Human (String name, int age, boolean sex) { this.name = name; this.age = age; this.sex = sex; } public Human(String name, int age, boolean sex, ArrayList<Human> children) { this.name = name; this.age = age; this.sex = sex; this.children = children; } public String toString() { String text = ""; text += "Name: " + this.name; text += ", sex: " + (this.sex ? "male" : "female"); text += ", age: " + this.age; int childCount = this.children.size(); if (childCount > 0) { text += ", children: " + this.children.get(0).name; for (int i = 1; i < childCount; i++) { Human child = this.children.get(i); text += ", " + child.name; } } return text; } } }

Comments (7)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

14 October 2020, 15:43

lines 39-47 are incorrect. Remove the String from each and just output each of the objects. *Tip* the println() method calls .toString() on all objects passed to it, you don't need to specifically do so these 2 lines are exactly the same:

System.out.println(child1.toString());
System.out.println(child1);

Cam

Level 15 , Bogota, Colombia

14 October 2020, 17:12

awesome, I did not know that. However it seems that unfortunately that isn't what is failing in my logic. ~(*.*)~

Guadalupe Gagnon

Level 37 , Tampa, United States

14 October 2020, 17:23

What does your code look like now?

Jan Elšík

Level 41 , Prague, Czech Republic

14 October 2020, 18:07

Have you tried to output the objects in the order that the task says? e.g.: first grandfather second grandfather first grandmother second grandmother father mother child1 child2 child3 Also at the start of human class, I don't think you have to initialize the variables. Aaaand I think you have too many constructors - the one on lines 67-72 is sufficient for the task.

Cam

Level 15 , Bogota, Colombia

14 October 2020, 18:18

I can only copy-paste what main looks like, anyway everything else is the same

public static void main(String[] args) {

    ArrayList<Human> childrens = new ArrayList<>();

    Human child1 = new Human("Walter", 31, true, childrens);
    Human child2 = new Human("Paula", 24, false, childrens);
    Human child3 = new Human("Jose", 29, true, childrens);

    ArrayList<Human> children = new ArrayList<>();
    children.add(child1);
    children.add(child2);
    children.add(child3);

    Human mother = new Human("Andrea", 47, false, children);
    Human father = new Human("Pedro", 50, true, children);

    ArrayList<Human> maternal = new ArrayList<>();
    maternal.add(mother);

    Human granma = new Human("Gloria", 69, false, maternal);
    Human granpa = new Human("Mario", 73, true, maternal);

    ArrayList<Human> paternal = new ArrayList<>();
    paternal.add(father);

    Human grandPa1 = new Human("Salomon", 76, true, paternal);
    Human grandMa1 = new Human("Teresa", 70, false, paternal);

    System.out.println("paternal Granfather is: " + grandPa1);
    System.out.println("paternal Granmother is: " + grandMa1);
    System.out.println("Maternal Granfather is: " + granma);
    System.out.println("Maternal GranMother is: " + granpa);
    System.out.println("Father is: " + father);
    System.out.println("Mother is : " + mother);
    System.out.println("Children are: " + child1);
    System.out.println("Children are: " + child2);
    System.out.println("Children are: " + child3);
}

Guadalupe Gagnon

Level 37 , Tampa, United States

14 October 2020, 18:34

The String needs to be removed from lines 29-37. For example line 29 should not be:

System.out.println("paternal Granfather is: " + grandPa1);

but instead

System.out.println(grandPa1);

Cam

Level 15 , Bogota, Colombia

14 October 2020, 18:41

Hahahaha thank you man, awesome I guess I read too much into the tasks