What's wrong with my code !!!

Question about the task

Longest sequence

Java Syntax, Level 8, Lesson 6

Resolved

Hello, When i run the program with any simulation its work, but the mentor doesnt accepte it. could you help me?

1. Create a list of numbers.
2. Use the keyboard to add 10 numbers to the list.
3. Display the length of the longest sequence of repeating numbers in the list.

Example for the list 2, 4, 4, 4, 8, 8, 4, 12, 12, 14:
3

The value is 3, because the longest sequence of repeating numbers is three fours.

Requirements:

The program must display a number on the screen.
The program should read values from the keyboard.
In the main method, declare an ArrayList variable with Integer elements and immediately initialize it.
The program should add 10 numbers to the collection in accordance with the conditions.
The program should display the length of the longest sequence of repeating numbers in the list.

package com.codegym.task.task08.task0812; import java.io.*; import java.util.ArrayList; /* Longest sequence */ public class Solution { public static void main(String[] args) throws IOException { ArrayList<Integer> list = new ArrayList<>(); BufferedReader kbd = new BufferedReader( new InputStreamReader( System.in ) ); for (int i = 0; i < 10; i++) { list.add( Integer.parseInt( kbd.readLine() ) ); } int longestSequenceB = 1; int longestSequenceE = 0; for (int i = 0; i < list.size() - 1; i++) { if (list.get( i ).equals( list.get( i + 1 ) )) { longestSequenceB++; } if (!list.get( i ).equals( list.get( i + 1 ) ) && longestSequenceB > longestSequenceE) { longestSequenceE = longestSequenceB; longestSequenceB = 1; } } System.out.println( longestSequenceE ); } }

Comments (1)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

24 December 2018, 20:56

#1 you dont need if (!list.get( i ).equals( list.get( i + 1 ) just tack an else block onto the first if statement. #2 you should reset the longestSequenceB every time that the 2 test variables come back as different, but your code only does it if they are different AND LSB > LSE. this is creating a bug in your program with strange results. This is how your for block should look:

for (int i = 0; i < list.size()-1; i++) {
     if (list.get(i) == list.get( i + 1 ))
         longestSequenceB++;
     else{
         if (longestSequenceB > longestSequenceE)
             longestSequenceE = longestSequenceB;
         longestSequenceB = 1;
     }
}