On paper everything is fine, even read many - java help on CodeGym

public class Solution {

    public static int countFirstName = 0;
    public static int countLastName = 0;

    public static HashMap<String, String> createMap() {
        //write your code here
        HashMap<String, String> mapOfNames = new HashMap<>();
        mapOfNames.put("Andrei", "Damigeana");
        mapOfNames.put("Florin", "Damigeana");
        mapOfNames.put("MIoara", "Geana");
        mapOfNames.put("Victor", "Damigeana");
        mapOfNames.put("Diana", "Brotac");
        mapOfNames.put("Cristiana", "Brotac");
        mapOfNames.put("Nelu", "Brotac");
        mapOfNames.put("Camelia", "Brotac");
        mapOfNames.put("Daniel", "Daniel");
        mapOfNames.put("Damiana", "Damiana");

        return mapOfNames;
    }

    public static int getSameFirstNameCount(HashMap<String, String> map, String name) {
        for (Map.Entry<String, String> pair : map.entrySet())
            if (pair.getValue().equals(name)) countFirstName++;

        return countFirstName;
    }

    public static int getSameLastNameCount(HashMap<String, String> map, String lastName) {
        for (Map.Entry<String,String> pair2 : map.entrySet())
            if (pair2.getKey().equals(lastName)) countLastName++;

        return countLastName;
    }

    public static void main(String[] args) {
      /*  System.out.println(getSameFirstNameCount(createMap(), "Damigeana"));
        System.out.println(getSameLastNameCount(createMap(), "Andrei"));
        */
    }
}

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

horst

Level 26 , Not in list

3 November 2020, 12:28

solution

Looking pretty good, I don't see any real mistakes. I'm a bit confused by your use of first/last-name, but in your methods it looks correct (last name should be first entry of the map(key) and fist name should be second entry (value)). The only possible problem I see is with your static countFirstName/countLastName-variables. As far as I know, the static variables are initialized to zero only once at compile-time, but after that never set back to zero. My guess is that with each call of one of the getCount-methods the counter-variable simply gets incremented and incremented and incremented... Try using locale variables inside the method's bodies that are set to zero at the beginning of the method's body. Or try setting your currently existing static variables back to zero at the beginning of the method's body:

public static int getSameFirstNameCount(HashMap<String, String> map, String name) {
        countFirstName = 0;
        for ...

Andrei

Level 41

3 November 2020, 13:09

Hi Horst! Thank you, actually that was it! Declaring variables locally sorted the problem. :)

Neil Hainer

Level 25 , Mount Laurel, United States

27 November 2020, 14:44

I believe static variables are initialized to zero at run-time not compile-time.

27 November 2020, 16:31

I believe you are right, Neil. https://www.baeldung.com/java-static-variables-initialization

On paper everything is fine, even read many other comments to the problem and the Help section, still, not passing verification.