This works in my compiler, but not in codeJudge?

Question about the task

Task about algorithms

Java Syntax, Level 5, Lesson 12

Resolved

Do anyone know why?

Write a program that:
1. reads a number N (must be greater than 0) from the console
2. reads N numbers from the console
3. Displays the maximum of the N entered numbers.

Requirements:

The program should read the numbers from the keyboard.
The program must display a number on the screen.
The class must have a public static void main method.
Don't add new methods to the Solution class.
The program should display the maximum of the N entered numbers.
The program should not display anything if N is less than or equal to 0.

package com.codegym.task.task05.task0532; /* Task about algorithms */ import java.util.Scanner; public class Solution { public static void main(String[] args) throws Exception { Scanner sc = new Scanner(System.in); int maximum = 0; while (true) { int inputNumber = sc.nextInt(); if (inputNumber <= 0) { break; } else { maximum = Math.max(maximum, inputNumber); } } if (maximum == 0) { } else { System.out.println(maximum); } } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Joe M

Level 47 , Owings Mills, United States

14 November 2020, 01:59

Always try to be specific and descriptive with variable names. So I would try

System.out.println ("Enter the number of numbers:");
int numOfNumbers = sc.nextInt();

in line 13. Then you set maximum to 0. Good! Then a "for" maybe

for (int i = 0; i < numOfNumbers; i ++){
            int inputNumber = sc.nextInt();
            if (inputNumber <= 0) {
                break;
            } else {
                maximum = Math.max(maximum, inputNumber);
                System.out.println(maximum);
           }
}

Switch/Cypher

Level 25 , Bexleyheath, United Kingdom

9 November 2020, 22:31

solution

It fails because it wants the first number you enter to be the number of numbers you will find the maximum of. So: first entry = 5; That means you need to read five further numbers then find the maximum. Your code keeps accepting numbers until something less than zero is entered.