Verification fails, code works

Question about the task

Resolved

Any reason this fails? code finds words "horizontally, vertically, and diagonally, both forward and backward", even with much larger word searches. Still fails with no explanation as to why.

1. We have a two-dimensional array that contains lowercase letters.
2. The detectAllWords method must find all the words in the wordSearch array.
3. The element(startX, startY) must correspond to the first letter of the word, while the element(endX, endY) corresponds to the last letter.
text is the word itself, located between the start and end elements
4. All the words are in the array.
5. The words can be arranged horizontally, vertically, and diagonally, both forward and backward.
6. The main method is not tested.

Requirements:

The Solution class must have a detectAllWords method.
The Solution class must contain a static Word class.
The Solution class must not have static fields.
The detectAllWords method must be static.
The detectAllWords method must be public.
The detectAllWords method should return the list of all words in the word search (according to the task conditions).

package com.codegym.task.task20.task2027; import java.util.LinkedHashMap; import java.util.LinkedList; import java.util.List; import java.util.Map; /* Word search */ public class Solution { public static void main(String[] args) { int[][] wordSearch = new int[][]{ {'f', 'd', 'e', 'r', 'l', 'k'}, {'u', 's', 'a', 'm', 'e', 'o'}, {'l', 'n', 'g', 'r', 'o', 'v'}, {'m', 'l', 'p', 'r', 'r', 'h'}, {'p', 'o', 'e', 'e', 'j', 'j'} }; detectAllWords(wordSearch, "home", "same"); /* Expected result home - (5, 3) - (2, 0) same - (1, 1) - (4, 1) */ } public static List<Word> detectAllWords(int[][] wordSearch, String... words) { int maxX = wordSearch[0].length, maxY = wordSearch.length; LinkedHashMap<int[],Integer> wordPlacement; List<Word> confirmedValues = new LinkedList<>(); for (String word :words){ wordPlacement = new LinkedHashMap<>(); int firstChar = word.charAt(0), lastChar = word.charAt(word.length()-1), wordLength = word.length(); boolean found = false; for(int y = 0;y < maxY;y++){ if(found)break; for(int x = 0; x < maxX; x++){ if(found) break; if(wordSearch[y][x] == firstChar || wordSearch[y][x] == lastChar){ //check diag back if(y + wordLength <= maxY && x + 1 - wordLength >= 0){ wordPlacement.clear(); wordPlacement.put(new int[]{x,y},wordSearch[y][x]); int count = 1; int y1= y+1; for(int x1 = x - 1; x1 >= x+1-wordLength;x1--){ if(wordSearch[y1][x1] == word.charAt(count) ||wordSearch[y1][x1] == word.charAt(word.length()-1-count)){ count++; wordPlacement.put(new int[]{x1,y1},wordSearch[y1][x1]); y1++; found = true; } else{ found = false; break; } } if(found) { confirmedValues.add(addWordToClass(wordPlacement,word)); break; } } // check down if(y + wordLength <= maxY){ wordPlacement.clear(); wordPlacement.put(new int[]{x,y},wordSearch[y][x]); int count = 1; for(int y1 = y + 1; y1 < y+wordLength;y1++){ if(wordSearch[y1][x] == word.charAt(count) ||wordSearch[y1][x] == word.charAt(word.length()-1-count)){ count++; wordPlacement.put(new int[]{x,y1},wordSearch[y1][x]); found = true; } else{ found = false; break; } } if(found) { confirmedValues.add(addWordToClass(wordPlacement,word)); break; } } // check diag forward if(y + wordLength <= maxY && x + wordLength <= maxX) { wordPlacement.clear(); wordPlacement.put(new int[]{x,y},wordSearch[y][x]); int count = 1; int y1= y+1; for(int x1 = x + 1; x1 < x+wordLength;x1++){ if(wordSearch[y1][x1] == word.charAt(count) ||wordSearch[y1][x1] == word.charAt(word.length()-1-count)){ count++; wordPlacement.put(new int[]{x1,y1},wordSearch[y1][x1]); y1++; found = true; } else{ wordPlacement.clear(); found = false; break; } } if(found) { confirmedValues.add(addWordToClass(wordPlacement,word)); break; } } // check forward if(x + wordLength <= maxX){ wordPlacement.clear(); wordPlacement.put(new int[]{x,y},wordSearch[y][x]); int count = 1; for(int x1 = x + 1; x1 < x+wordLength;x1++){ if(wordSearch[y][x1] == word.charAt(count) ||wordSearch[y][x1] == word.charAt(word.length()-1-count)){ count++; wordPlacement.put(new int[]{x1,y},wordSearch[y][x1]); found = true; } else{ found = false; break; } } if(found) { confirmedValues.add(addWordToClass(wordPlacement,word)); break; } } } } } } return confirmedValues; } private static Word addWordToClass(LinkedHashMap<int[], Integer> wordPlacement, String word) { Word tempReturn = new Word(word); boolean forwards = true; int[] firstPlots = new int[2], lastplots = new int[2]; for(Map.Entry<int[],Integer> pair : wordPlacement.entrySet()){ firstPlots[0] = pair.getKey()[0]; firstPlots[1] = pair.getKey()[1]; break; } int count = 0; for(Map.Entry<int[],Integer> pair : wordPlacement.entrySet()){ lastplots[0] = pair.getKey()[0]; lastplots[1] = pair.getKey()[1]; if(forwards) if(pair.getValue() != word.charAt(count++)) forwards = false; } if(forwards){ tempReturn.setStartPoint(firstPlots[0],firstPlots[1]); tempReturn.setEndPoint(lastplots[0],lastplots[1]); }else { tempReturn.setEndPoint(firstPlots[0],firstPlots[1]); tempReturn.setStartPoint(lastplots[0],lastplots[1]); } return tempReturn; } public static class Word { private String text; private int startX; private int startY; private int endX; private int endY; public Word(String text) { this.text = text; } public void setStartPoint(int i, int j) { startX = i; startY = j; } public void setEndPoint(int i, int j) { endX = i; endY = j; } @Override public String toString() { return String.format("%s - (%d, %d) - (%d, %d)", text, startX, startY, endX, endY); } } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Roman

Level 41

9 January 2019, 06:37

solution

Try to check your solution using this main method:

public static void main(String[] args) {
        int[][] wordSearch = new int[][]{
                //0    1    2    3    4    5    6
                {'f', 'd', 'e', 'r', 'l', 'k', 'x'},// 0
                {'u', 's', 'a', 'm', 'e', 'o', 'd'},// 1
                {'l', 'n', 'g', 'r', 'o', 'v', 'z'},// 2
                {'m', 'l', 'p', 'r', 'r', 'h', 'w'},// 3
                {'p', 'o', 'e', 'e', 'a', 'a', 'c'},// 4
                {'u', 's', 'a', 'm', 'a', 'a', 'd'},// 5
                {'l', 'n', 'g', 'r', 'a', 'a', 'z'},// 6
                {'m', 'l', 'p', 'r', 'a', 'a', 'w'},// 7
                {'p', 'o', 'e', 'q', 's', 'a', 'c'},// 8
                {'f', 'd', 'e', 'r', 'a', 'a', 'x'},// 9
        };
        detectAllWords(wordSearch, "qsa");
        /*
Expected result
qsa - (3, 8) - (5, 8)
         */
    }

Guadalupe Gagnon

Level 37 , Tampa, United States

9 January 2019, 14:36

Thank you! I ran your matrix with my code and it spit out something completely different. I have stepped through my code and found where the mistake is occurring(bug). I expect a solve shortly when I make the needed corrections.

Guadalupe Gagnon

Level 37 , Tampa, United States

9 January 2019, 15:36

Passed!