I keep failing the first 2 requirement

Question about the task

Under discussion

Hello, I keep failing the first 2 requirements. I get this mentor comment on the first requirement " The direction of the ball's movement after a collision with a brick (an element in the list of bricks) must be changed in accordance with the rule stipulated in the task conditions." I copied the code in the conditions . I am lost. any help is appreciated.

There's just a little bit left.

Create a private boolean isGameOver field in the Arkanoid class.

Implement the checkBrickCollision method.
In this method, you need to check whether the ball has collided with any of the bricks.
Use the intersects method to test for a collision.
If the ball does hit a brick, then:
a) the ball flies off in a random direction:
double angle = Math.random() * 360;
ball.setDirection(angle);
b) the brick "dies" and must be removed from the list of bricks.

Implement the checkPaddleCollision method.
In this method, you need to check whether the ball has hit the paddle.
Use the intersects method to test for a collision.
If the ball does hit the paddle, then:
the ball flies up in a random direction:
double angle = 90 + 20 * (Math.random() - 0.5);
ball.setDirection(angle);

Implement the checkGameOver method.
If the ball's y coordinate is greater than the height of the game field (height), then the ball has flown off the bottom of the screen.
If this happens, set the isGameOver variable to true.

Requirements:

The Arkanoid class must implement a checkBrickCollision() method in accordance with the task conditions.
The Arkanoid class must implement a checkPaddleCollision() method in accordance with the task conditions.
A private boolean isGameOver field must be created in the Arkanoid class.
The Arkanoid class must implement a checkGameOver() method in accordance with the task conditions.

package com.codegym.task.task24.task2413; public class Ball extends BaseObject { // Speed private double speed; // Direction (0 to 360 degrees) private double direction; // Current direction vector (dx, dy) private double dx; private double dy; // Is the object frozen or movable? private boolean isFrozen; public Ball(double x, double y, double speed, double direction) { super(x, y, 1); this.direction = direction; this.speed = speed; this.isFrozen = true; } public double getSpeed() { return speed; } public double getDirection() { return direction; } public double getDx() { return dx; } public double getDy() { return dy; } @Override void draw(Canvas canvas) { canvas.setPoint(x, y, 'O'); } @Override void move() { if (!isFrozen) { x += dx; y += dy; } } public void start() { this.isFrozen = false; } public void setDirection(double direction) { this.direction = direction; double angle = Math.toRadians(direction); dx = Math.cos(angle) * speed; dy = -Math.sin(angle) * speed; } public void checkRebound(int minx, int maxx, int miny, int maxy) { } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

jpcouturier

Level 29 , France , France

2 February 2024, 14:47

had the same issue. For me it was because i added an extra-check in Ball class on setDirection method (it was said that the direction is a value between 0 and 360, so I checked it) It seems that interfer with their automated code validation at this part despite it was validated previously.

Nouser

Level 36 , Germany

14 December 2020, 14:51

Inside the brick collision method you probably added the break cause it can throw exceptions? However that way you just can remove one brick per move. If the ball touches two, your code won't work. To delete collection elements inside a loop doesn't work well (ConcurrentModificationException). So either you could use iterators or you loop over a copy of bricks and remove the elements in the original bricks list.

for (Brick brick : new ArrayList<Brick>(bricks)) {

Don't forget to delete the break statement. The other method looks OK, maybe it's becoming green once you fixed brick collision

Fadi Alsaidi

Level 34 , Carrollton, TX , USA

14 December 2020, 15:51

Thank you Nouser for your suggestion :) Unfortunately I did try that and still wouldn't clear the first requirement. I added "break;" ,even though it made no sense, based on someone suggestion in the help section. It's very odd. the issue, based on the validation comment, is in the direction of the ball ?!!! so odd. this is the the rewrite of the method with both of your suggestion public void checkBrickCollision() { for (Brick brick : new ArrayList<Brick>(bricks)){ if (ball.intersects(brick)) { double angle = Math.random() * 360; ball.setDirection(angle); bricks.remove(brick); } } public void checkBrickCollision() { Iterator<Brick> it = bricks.iterator(); while (it.hasNext()){ if(ball.intersects(it.next())){ double angle = Math.random() * 360; ball.setDirection(angle); it.remove(); } } }

Nouser

Level 36 , Germany

14 December 2020, 16:29

here's what I have. And that's from CodeGym cause they overwrite code every now and then in the big tasks

void checkBrickCollision() {
    for (Brick brick : new ArrayList<Brick>(bricks)) {
        if (ball.intersects(brick)) {
            double angle = Math.random() * 360;
            ball.setDirection(angle);

            bricks.remove(brick);
        }
    }
}

despite the public modfier they seem to be identical. Your intersects method looks good, too. Maybe try to reset the task?

Fadi Alsaidi

Level 34 , Carrollton, TX , USA

14 December 2020, 23:51

Thank you so much Nouser. I will give the rest a shot and see what happens.