Father and Mother print failing validation. Cannot see it...

Question about the task

Resolved

Father and Mother print failing validation. Cannot see it... Please advise.

Task: Each cat has a name and a mother.
Create a class that describes this situation.
Create two objects: a daughter cat and a mother.
Display them on the screen.

New task: Each cat has a name, a father, and a mother.
Edit Cat so that it reflects these relationships.
Create 6 objects: grandfather (the father's father), grandmother (the mother's mother), father, mother, son, daughter.
Display them all in the following order: grandfather, grandmother, father, mother, son, daughter.

Example input:
Grandfather Tiger Grandmother Puss Father Oscar Mother Missy Son Simba Daughter Coco

Example output:
The cat's name is Grandfather Tiger, no mother, no father The cat's name is Grandmother Puss, no mother, no father The cat's name is Father Oscar, no mother, Grandfather Tiger is the father The cat's name is Mother Missy, Grandmother Puss is the mother, no father The cat's name is Son Simba, Mother Missy is the mother, Father Oscar is the father The cat's name is Daughter Coco, Mother Missy is the mother, Father Oscar is the father

Requirements:

The program should read in the names of 6 cats in the specified order.
The main method should create 6 Cat objects.
The program should display 6 lines with information about the cats.
The line about the grandfather (first line) must match the conditions.
The line about the grandmother (second line) must match the conditions.
The line about the father (third line) must match the conditions.
The line about the mother (fourth line) must match the conditions.
The line about the son (fifth line) must match the conditions.
The line about the daughter (sixth line) must match the conditions.

package com.codegym.task.task06.task0621; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; /* Cat relations */ public class Solution { public static void main(String[] args) throws IOException { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); String GrandfatherName = reader.readLine(); Cat catGrandfather = new Cat(GrandfatherName); String GrandmotherName = reader.readLine(); Cat catGrandmother = new Cat(GrandmotherName); String fatherName = reader.readLine(); Cat catFather = new Cat(fatherName, catGrandfather); String motherName = reader.readLine(); Cat catMother = new Cat(motherName, catGrandmother); String sonName = reader.readLine(); Cat catSon = new Cat(sonName, catFather, catMother ); String daughterName = reader.readLine(); Cat catDaughter = new Cat(daughterName, catFather, catMother ); System.out.println(catGrandfather); System.out.println(catGrandmother); System.out.println(catFather); System.out.println(catMother); System.out.println(catSon); System.out.println(catDaughter); } public static class Cat { private String name; private Cat parent; private Cat mother; private Cat father; Cat(String name) { this.name = name; } Cat(String name, Cat parent) { this.name = name; this.parent = parent; if (this.parent.name.startsWith("Father")) this.father = parent; else if (this.parent.name.startsWith("Grandfather")) this.father = parent; else if (this.parent.name.startsWith("Mother")) this.mother = parent; else if (this.parent.name.startsWith("Grandmother")) this.mother = parent; } Cat(String name, Cat father, Cat mother) { this.name = name; this.father = father; this.mother = mother; } @Override public String toString() { if (mother == null && father != null) return "The cat's name is " + name + ", no mother, "+ this.parent.name + " is the father"; else if (father == null && mother != null) return "The cat's name is " + name + ", "+ this.parent.name + " is the mother"+ ", no father "; else if (father != null && mother != null) return "The cat's name is " + name + ", " + mother.name + ", is the mother, " + father.name + " is the father"; else return "The cat's name is " + name + ", " + "no mother, " + "no father"; } } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

iqbalhussain

Level 22 , Peshawar, Pakistan

28 January 2019, 13:10

public static class Cat { private String name; //private Cat parent; private Cat mother; private Cat father; Cat(String name) { this.name = name; } Cat(String name, Cat father, Cat mother) { this.name = name; this.father = father; this.mother = mother; } @Override public String toString() { if (mother == null && father != null) return "The cat's name is " + name + ", no mother, "+ this.father.name + " is the father"; else if (father == null && mother != null) return "The cat's name is " + name + ", "+ this.mother.name + " is the mother"+ ", no father "; else if (father != null && mother != null) return "The cat's name is " + name + ", " + this.mother.name + ", is the mother, " +this.father.name + " is the father"; else return "The cat's name is " + name + ", " + "no mother, " + "no father"; } }

iqbalhussain

Level 22 , Peshawar, Pakistan

28 January 2019, 13:09

Solution BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); String GrandfatherName = reader.readLine(); Cat catGrandfather = new Cat(GrandfatherName); String GrandmotherName = reader.readLine(); Cat catGrandmother = new Cat(GrandmotherName); String fatherName = reader.readLine(); Cat catFather = new Cat(fatherName, catGrandfather,null); String motherName = reader.readLine(); Cat catMother = new Cat(motherName, null, catGrandmother); String sonName = reader.readLine(); Cat catSon = new Cat(sonName, catFather, catMother ); String daughterName = reader.readLine(); Cat catDaughter = new Cat(daughterName, catFather, catMother ); System.out.println(catGrandfather); System.out.println(catGrandmother); System.out.println(catFather); System.out.println(catMother); System.out.println(catSon); System.out.println(catDaughter); }

Rose

Level 14 , Richardson, United States

2 July 2020, 21:01

thank you. null in the constructor saved the situation

Jyothi

Level 20 , United States

3 January 2019, 22:34

Thanks. Did exactly that. worked on the first try. Never thought to pass null to constructor but worked.

Guadalupe Gagnon

Level 37 , Tampa, United States

3 January 2019, 21:29

This whole block of code is bad and assumes that the user will enter the words specified, if they just use Tiger, Puss, Oscar, Missy, Simba, Coco then the code will fail. Rewrite your main block to only use the other two constructors and comment on this one below:

Cat(String name, Cat parent) {
    this.name = name;
    this.parent = parent;
    if (this.parent.name.startsWith("Father"))
    this.father = parent;
    else if (this.parent.name.startsWith("Grandfather"))
    this.father = parent;
    else if (this.parent.name.startsWith("Mother"))
    this.mother = parent;
    else if (this.parent.name.startsWith("Grandmother"))
    this.mother = parent;
 }

Also too many member variables, they should only be name, mother, and father. Get rid of 'parent'.