I don't get

Question about the task

Under discussion

I have made my code as simple to follow as possible and in my head everything works fine and in the code looks OK, but still I get: - "The countMineNeighbors() method should, for each non-mined cell in the gameField matrix, count the number of adjacent mined cells and assign this value to the countMineNeighbors field." "It looks like you counted the number of adjacent mines for a cell that is a mine — don't do that." - The countMineNeighbors() method should use the getNeighbors(GameObject gameObject) method. - In the createGame() method, after all the elements of the gameField matrix are created, the countMineNeighbors() method must be called. i don't get it why? Any help?

Now let's count the mines in adjacent cells. To do this, we'll add a field to each cell of the matrix, which will be responsible for the number of mined neighbors. First, we find all the neighbors, and then we count how many of them are mined.

To get the list of neighbors, you now have the getNeighbors() method, which has one GameObject (cell) parameter.

Your task is to, in a separate method, count the number of mined neighbors for each cell in gameField and assign this value to the appropriate field of the cell.

Although your work is not visible (you started program to see what happens, right?), it is very important to future steps.

Requirements:

The GameObject class must have a public int countMineNeighbors field.
The MinesweeperGame class must have a private void countMineNeighbors() method.
The countMineNeighbors() method should, for each non-mined cell in the gameField matrix, count the number of adjacent mined cells and assign this value to the countMineNeighbors field.
The countMineNeighbors() method should use the getNeighbors(GameObject gameObject) method.
In the createGame() method, after all the elements of the gameField matrix are created, the countMineNeighbors() method must be called.

package com.codegym.games.minesweeper; public class GameObject { public int x; public int y; public boolean isMine; public int countMineNeighbors; public GameObject(int newX, int newY, boolean setMine){ this.x = newX; this.y = newY; this.isMine = setMine; } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Jesper

Level 0 , Netherlands

8 April 2021, 08:57

i do it in code:

private void countMineNeighbors() {
    for (int y = 0; y < SIDE; y++) {
        for (int x = 0; x < SIDE; x++) {
            GameObject gameObject = gameField[y][x];

            if (!gameObject.isMine) {
                gameObject.countMineNeighbors = Math.toIntExact(getNeighbors(gameObject).stream().filter(neighbor -> neighbor.isMine).count());
            }
        }
    }
}

Jesper

Level 0 , Netherlands

8 April 2021, 08:37

Oh no, it's an private int countMineNeighbors(), and not an private List<GameObject> countMineNeighbors()

Jesper

Level 0 , Netherlands

8 April 2021, 08:35

First, you have to get an private List<GameObject> countMineNeighbors() { } Then, in countMineNeighbors(), you have to get this in your countMineNeighbors method: for (int y = 0; y < SIDE; y++) { for (int x = 0; x < SIDE; x++) { GameObject gameObject = gameField[y][x]; if (!gameObject.isMine) { gameObject.countMineNeighbors = Math.toIntExact(getNeighbors(gameObject).stream().filter(neightbor -> neightbor.isMine).count()); } } }

Nouser

Level 36 , Germany

3 April 2021, 22:22

useful

Line 22, just create the reference variable, the getNeigbors method is assigning a List later. Comment out line 30. The rest looks good inside that method as far as I can see (not tested). But are you sure your getNeighbors method works as expected? Looks a little bit quirky to me ;) The first line is OK, then I suggest to create two nested loops, y and x. y from gameObject.y - 1 to gameObject.y + 1 and the same for gameObject.x for x. That will hit all fields around the gameObject field (including the gameObject field) now check if you're inside the game field boundaries (is y >= 0 && < SIDE), do the same check for x. And also check if gameField[y][x] != gameObject (excluding the gameObject field). Then add gameField[y][x] to the list. That's it. A handful lines of code.