Think I know what the problem is - not sure how to solve it

Question about the task

Resolved

Relevant code is on lines 132-182. I have a feeling that the problem is that the Paths being added to the List on line 148 is the full Path and therefore the condition on line 162 is always false. Not sure how to get a "simple name", especially if it's in a sub-folder, how would I get the correct "amount" of Path?

There's just one small trifle left: adding a file to an archive. It sounds shady, but that's exactly what we're going to do.
Adding files is similar to removing them: we create a temporary archive file, copy over all of the old archive's contents, and then add the new files. Then we replace the old archive file with the new one.
1. Add a public void addFiles(List<Path> absolutePathList) throws Exception method to the ZipFileManager class, where absolutePathList is a list of absolute paths to the files to be added.
This method must:
1.1. As usual, throw a NoSuchZipFileException if the archive file doesn't exist
1.2. Create a temporary archive file
1.3. Go through all the files in the original archive. Copy each file to the new archive, and add its name to a local list.
1.4. Go through the list of files to add.
1.5. Check whether each file exists and whether it is a regular file. If something isn't right, then throw a PathNotFoundException.
1.6. Check whether the file to be added is already in the archive (use the list in step 1.3). This is possible if the user has already added it.
- If the file isn't in the list, add it to the new archive and display a message indicating that the file was added to the archive
- If the file is in the list, just tell the user that the file already exists in the archive
1.7. Replace the original archive file with the temporary file, which already has all of the added files.
2. Add a public void addFile(Path absolutePath) throws Exception method to the ZipFileManager class, and implement it by calling the addFiles(), method—by analogy with what we did for removing a file.
3. Implement the ZipAddCommand class's execute() method. It's business as usual here, but don't forget to ask the user which file to add to which archive, and handle the PathNotFoundException that might be thrown by the addFile() method.
4. Run the program and verify that adding a file now works.

Requirements:

You need to create a public void addFiles(List<Path> absolutePathList) throws Exception method in the ZipFileManager class.
The addFiles method must throw a NoSuchZipFileException if the archive file doesn't exist.
The addFiles method must create a temporary archive file using the Files.createTempFile method.
The addFiles method must go through the list of files to be added and throw a PathNotFoundException if a file doesn't exist.
The addFiles method must write the new files as well as all of the old archive's files to the new archive. Then replace the old archive with the new one.
In the ZipFileManager class, you need to create a public void addFile(Path absolutePath) throws Exception method that delegates the call to the addFiles(List<Path> absolutePathList) method.
The ZipAddCommand class's execute() method must get the ZipFileManager object, and add the file read from the console to the archive.

package com.codegym.task.task31.task3110; import com.codegym.task.task31.task3110.exception.NoSuchZipFileException; import java.io.IOException; public class Archiver { public static void main(String[] args) throws IOException { Operation operation = null; do { try { operation = askOperation(); CommandExecutor.execute(operation); } catch (NoSuchZipFileException e) { ConsoleHelper.writeMessage("You didn't select an archive or you selected an invalid file."); } catch (Exception e) { ConsoleHelper.writeMessage("An error occurred. Please check the entered data."); } } while (operation != Operation.EXIT); } public static Operation askOperation() throws IOException { ConsoleHelper.writeMessage(""); ConsoleHelper.writeMessage("Select an operation:"); ConsoleHelper.writeMessage(String.format("\t %d - Zip files into an archive", Operation.CREATE.ordinal())); ConsoleHelper.writeMessage(String.format("\t %d - Add a file to an archive", Operation.ADD.ordinal())); ConsoleHelper.writeMessage(String.format("\t %d - Remove a file from an archive", Operation.REMOVE.ordinal())); ConsoleHelper.writeMessage(String.format("\t %d - Extract an archive", Operation.EXTRACT.ordinal())); ConsoleHelper.writeMessage(String.format("\t %d - View the contents of an archive", Operation.CONTENT.ordinal())); ConsoleHelper.writeMessage(String.format("\t %d - Exit", Operation.EXIT.ordinal())); return Operation.values()[ConsoleHelper.readInt()]; } }

Comments (7)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

15 April 2021, 16:31

useful

close... The "path" varaible (each path in absolutePathList) is the full qualified path: "C:\users\something\foo\file.txt" That wont be what is in the "addedFiles" from everything that was added above. This means that line 165 will always be "true" (file NOT added), regardless if it has already been added. You will only want to pass in the file name, not the full path.

Guadalupe Gagnon

Level 37 , Tampa, United States

15 April 2021, 16:38

useful

When you are ready, learn HTML and CSS. They are waaaaay easier than Java (serve a much different purpose) but deal with absolute file paths vs relative file paths quite regularly.

Anthony Chalk

Level 30 , London, United Kingdom

15 April 2021, 19:00

public void addFiles(List<Path> absolutePathList) throws Exception{
    if (!Files.isRegularFile(zipFile)) {
        throw new NoSuchZipFileException();
    }

    Path tempZipFile = Files.createTempFile(null, null);

    try (ZipOutputStream zipOutputStream = new ZipOutputStream(Files.newOutputStream(tempZipFile))) {
        try (ZipInputStream zipInputStream = new ZipInputStream(Files.newInputStream(zipFile))) {

            List<String> addedFiles = new ArrayList<>();

            ZipEntry zipEntry = zipInputStream.getNextEntry();
            while (zipEntry != null) {

                Path archivedFile = Paths.get(zipEntry.getName());
                addedFiles.add(archivedFile.toFile().getName());

                String fileName = zipEntry.getName();
                zipOutputStream.putNextEntry(new ZipEntry(fileName));

                copyData(zipInputStream, zipOutputStream);

                zipOutputStream.closeEntry();
                zipInputStream.closeEntry();

                zipEntry = zipInputStream.getNextEntry();
            }

            for (Path path : absolutePathList){
                if (!Files.isRegularFile(path)){
                    throw new PathNotFoundException();
                }
                else if (!addedFiles.contains(path.toFile().getName())){
                    addNewZipEntry(zipOutputStream, path.getParent(), path.getFileName());
                    ConsoleHelper.writeMessage("File has been added to archive");
                }
                else {
                    ConsoleHelper.writeMessage("The file already exists in the archive.");
                }
            }
        }
    }

So I tried making a list of

path.toFile().getName()

but it's still fa

Anthony Chalk

Level 30 , London, United Kingdom

15 April 2021, 19:06

Any recommended resources for HTML/CSS?

Guadalupe Gagnon

Level 37 , Tampa, United States

15 April 2021, 19:10

I wouldn't recommend that you do it now, as it would just be a distraction to your overall learning, but save and later check out w3schools. This site actually has a bunch of lessons on many different languages, all free.

Guadalupe Gagnon

Level 37 , Tampa, United States

15 April 2021, 19:26

solution

As for the code: I think that your original List<Path> should have been sufficient instead of making it a List<String>. You can add the Paths directly from the loop reading the original zip file (which are relative paths). Then, in the next loop when adding the new files, (Path) path.getFileName() returns a Path, which would work on the line to see if it contained in the list already. however, with the code that you linked, I think you should be able to fix it by simply changing line 17. The way you had it before adds the relative path, the way you have it now just adds the file name. I think you want to add the relative path here. Change it to add the archivedFile.toString() instead of .toFile().getName();

Anthony Chalk

Level 30 , London, United Kingdom

15 April 2021, 19:36

Thank you very much