I'm missing something so many things

Question about the task

Under discussion

I keep checking solution to find out there is something new that they didn't go over in the lessons. it's just new and random.

package com.codegym.task.task02.task0216; /* Minimum of three numbers */ public class Solution { public static int min(int a, int b, int c) { //write your code here if (a < b){ if (a < c){ return a; } else (a > c){ return c; } } else (a > b){ if (a < c){ return b; } else(a > c){ return c; } } } public static void main(String[] args) throws Exception { System.out.println(min(1, 2, 3)); System.out.println(min(-1, -2, -3)); System.out.println(min(3, 5, 3)); System.out.println(min(5, 5, 10)); } }

Comments (1)

Popular
New
Old

You must be signed in to leave a comment

Thomas

Level 41 , Bayreuth, Germany

8 May 2021, 18:45

The first problem is a syntax issue. After else you do not check a condition. If you need to check another condition after an if clause you can use 'else if' like:

if (a < b) {
    // do something
} else if (b < c) {
   // do something else
} else {
    // execute another command
}

You started pretty good with (I added a brace)

if (a < b) {
    if (a < c) {
        return a;
    }
}

now if a is the smallest number, you already returned it, means it is out of the game and you do not need to take care of it anymore. Just b and c are of interest now. And that's prette easy ;) So you just check if b is smaller then c, if so, return it. Otherwise return c.

if (b < c)
    return b;

return c;

together that looks similar to

if (a < b && a < c)
    return a;
if (b < c)
    return b;
return c;

Here you do not need to use else if and else but it doesn't harm on the other hand, like

if (a < b && a < c) {
    return a;
} else if (b < c) {
    return b;
} else {
    return c;
}

shorter:

if (a < b && a < c)
    return a;
return (b < c) ? b : c;

even shorter:

return Math.min(Math.min(a, b), c);

And there are lots of other ways to solve that task. (all that code is untested but should work) And please try to better format your code. That helps a lot to avoid problems like nesting errors and to understand whats going on.