not seeing where this is incorrect....sample input is output correctly on IntelliJ....

Question about the task

Under discussion

package com.codegym.task.task05.task0532; import java.io.*; /* Task about algorithms */ public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int num = Integer.parseInt(reader.readLine()); int maximum = 0; if (num <= 0) { return; } while (num > 0) { num = Integer.parseInt(reader.readLine()); if (maximum < num) { maximum = num; } } System.out.println(maximum); } }

Write a program that:
1. reads a number N (must be greater than 0) from the console
2. reads N numbers from the console
3. Displays the maximum of the N entered numbers.

Requirements:

The program should read the numbers from the keyboard.
The program must display a number on the screen.
The class must have a public static void main method.
Don't add new methods to the Solution class.
The program should display the maximum of the N entered numbers.
The program should not display anything if N is less than or equal to 0.

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

3 August 2021, 03:45

I see that this code accepts user input for N that is called 'num' in code; however It checks that N is greater than or equal to 0 instead of just greater than 0, which is incorrect, and I don't see where the code then accepts N numbers from the user and determines which one is the max according to the task directions. Example inputs: 3 -2 -5 -4 correct output: -2 because that is the maximum of the 3 entered numbers another: 5 2 -1 3 4 -2 output: 4 because that is the maximum of the N entered numbers

ron_villela

Level 9 , Miami, United States

3 August 2021, 04:19

Thank you for the response. The last requirement states: The program should not display anything if N is less than or equal to 0. Which is my first “if” statement….so I interpret that to mean no negative numbers. My while loop finds the max and prints it. The code works fine on IntelliJ but I get an error on the site

java.lang.NumberFormatException:For input string: ""
	at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
	at java.lang.Integer.parseInt(Integer.java:592)
	at java.lang.Integer.parseInt(Integer.java:615)
	at com.codegym.task.task05.task0532.Solution.main(Solution.java:21)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

Thomas

Level 41 , Bayreuth, Germany

3 August 2021, 07:13

The first input must not be < 0. That's the number N. Then you enter the amount of N numbers and among those you determin the max. These N numbers may be smaller thatn zero. So your abort condition in the loop is not correct. Overwriting num doesn't help either.

Guadalupe Gagnon

Level 37 , Tampa, United States

3 August 2021, 13:24

useful

I stand corrected on the less than or equal to 0. The NumberFormatException is because the code is still incorrect in that it does not do condition #2 and condition #3. You have to do each one of those conditions independently. 1. reads a number N (must be greater than 0) from the console you do this correctly on line 14-18 2. reads N numbers from the console This is not done in the above code. The number N is going to be whatever the user input on step 1. So for step one, if the user enters 5, then this line would read: "2. reads 5 numbers from the console" 3. Displays the maximum of the N entered numbers. Because step 2 is not complete, step 3 is not able to be complete. Once again, N on this step is whatever the user input on step 1. If the user, entered 2 then this line would read: "3. Displays the maximum of the 2 entered numbers." You need to ensure that, on the website, the "Input Data" section has the correct information. If you have something like: 5 -2 -5 There are two problems with that: - the blank line will be read by the code and throw an exception - the first input, for N, is 5 but there are only 2 additional numbers instead of the required 5