Need help please

Question about the task

Maximum of four numbers

Java Syntax, Level 4, Lesson 6

Under discussion

Having trouble locating what exactly is wrong with my code. Help would be appreciated. Thanks.

package com.codegym.task.task04.task0419; /* Maximum of four numbers */ import java.io.*; public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); String a = reader.readLine(); String b = reader.readLine(); String c = reader.readLine(); String d = reader.readLine(); int e = Integer.parseInt(a); int f = Integer.parseInt(b); int g = Integer.parseInt(c); int h = Integer.parseInt(d); if ((e >= f) && (e >= g) && (e >= g)) System.out.println(e); else if ((f >= e) && (f >= g) && (f >= h)) System.out.println(f); else if ((g >= e) && (g >= f) && (g >= h)) System.out.println(g); else if ((h >= e) && (h >= f) && (h >= g)) System.out.println(h); else System.out.println(e); //Displaying e if numbers equal to each other. } }

Comments (8)

Popular
New
Old

You must be signed in to leave a comment

Deepak Chandra

Level 16 , Visakhapatnam, India

2 May 2019, 10:07

hey buddy you can try this instead but error is in your first if statement if ((e >= f) && (e >= g) && (e >= g)) the last one should be e >= h rather than e >= g again.You can also do like below

import java.util.Scanner;

public class Solution {
    public static void main(String[] args) {
        Scanner scanner = new Scanner(System.in);
        int a = scanner.nextInt();
        int b = scanner.nextInt();
        int c = scanner.nextInt();
        int d = scanner.nextInt();

        if (a >= b && a >= c && a >= d){
            System.out.println(a);
        }else if (b >= a && b >= c && b >= d){
            System.out.println(b);
        }else if (c >= b && c >= a && c >= d){
            System.out.println(c);
        }else if (d >= b && d >= c && d >= a){
            System.out.println(d);
        }else {
            System.out.println(b);
        }
        scanner.close();
    }
}

Radim Strapek

Level 6 , Prague, Czech Republic

29 April 2020, 19:26

Hey I have tryed your code, and its incorrect. The else statement does not make sense to me. //line 19 and 20

hidden #10426237

Level 7

23 February 2019, 20:06

Just replace printn with print and it will work.

Guadalupe Gagnon

Level 37 , Tampa, United States

22 January 2019, 14:27

There is a bug somewhere in your code. I input the values 5, 5, 2, 8 and the output was 5. (Hint: the bug is on line 22)

Multivac

Level 13 , Lima, Perú

22 January 2019, 14:04

Check your first if condition, you have duplicates. And also, you could improve your code: the first condition (after correction) would be to check wether "e" is the maximum value, and then you make an else-if statement. In this statement, you already know that "e" is NOT the maximum value, so you just have to check the rest values: f, g and h. In the next else-if you just have to check only the variables g and h, etc.

Guadalupe Gagnon

Level 37 , Tampa, United States

22 January 2019, 14:34

The op has no duplicates. I think you are confusing the input only lines that are strings and the lines that convert those strings to ints. A better optimization is to use Math.max():

System.out.println(Math.max(Math.max(n1,n2),Math.max(n3,n4)));

one line of code that replaces 10 lines

Multivac

Level 13 , Lima, Perú

22 January 2019, 18:07

Maybe I didn't explained myself correctly, I was also talking about what you said. He compared the same values twice, that is what I meant with "duplicates". And about the max function, well I don't remember if he already knows about libraries at level 4. But thank you for clearing things up!

Guadalupe Gagnon

Level 37 , Tampa, United States

22 January 2019, 18:49

My bad, I thought you meant the first condition of the task requirements: "The program should read the numbers from the keyboard." That little word 'if' didn't stick out when i first read your response.