Por que esta?

Question about the task

Greater than 10? You're not a good fit for us

Java Syntax, Level 14, Lesson 7

Resolved

So my code seems to fulfill all the requirements yet it is still failing.

package en.codegym.task.jdk13.task08.task0814; import java.util.HashSet; import java.util.Iterator; import java.util.Set; /* Greater than 10? You're not a good fit for us */ public class Solution { public static Set<Integer> createSet() { // write your code here Set<Integer> set = new HashSet<Integer>(); for (int i = 0; i < 20; i++) { set.add(i); } return set; } public static void removeAllNumbersGreaterThan10(Set<Integer> set) { // write your code here for (int i : set) { if (i > 10) { set.remove(i); } } } public static void main(String[] args) { } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Gellert Varga

Level 23 , Szekesfehervar, Hungary

21 December 2021, 20:25

solution

I don't know if you've tried Lisa's suggestion. I've added this code in main() to test if it works.

Set<Integer> hsh = createSet();
removeAllNumbersGreaterThan10(hsh);
System.out.println(hsh);

You do this too, to see how your program works! ((Whenever you code anything, constantly (very often) test what your written code does. If you add another 3-4 lines, test again to see if it still does what you want it to do. Place as many System.out.println commands as possible so that you can keep track of changes in the contents of variables. I don't know how professional programmers would feel about this, but this is the only way I can tackle with increasingly complex tasks.)) During testing, your code shared above will throw a ConcurrentModificationException and stop. You get this because in a "for (int i : set)" loop you should not use "set.remove(i)". You can use this simplified iteration to display items, but not to modify Set/List. For this, the more complex writing way must be used, creating an Iterator object. I remember a CG lesson showed the exact way to do this.

Gellert Varga

Level 23 , Szekesfehervar, Hungary

21 December 2021, 20:53

P.S.: Use this formula to create an Iterator:

Iterator<Integer> iter = set.iterator();

and use the hasNext() method in a loop to check if there is another element, use the next() method to get the current element, and use the remove() method (without any argument) in the loop to delete an element.

Lisa

Level 41

21 December 2021, 10:27

Obviously you haven't tested your code. Otherwise you'd know that it does not fulfill the requirements. As a hint. A lot of the syntax quest tasks fail when you use Set or List as the reference variable type.