Not sure what I'm missing...

Question about the task

Under discussion

I have got this to pass all qualifications except the third, which is an arbitrary "implement fight method based on weight, age, and strength", which I have done, comparing each stat separately. And this code seems to work. Pardon all my //comments. Without any additional cues as to what I am doing wrong I am clueless. Thanks in advance for any help!!

Implement the boolean fight(Cat anotherCat) method: think up a mechanism for cat fighting depending on their weight, age, and strength.
Compare each attribute separately so that the winner is the one with the best performance in regards to the most attributes.

The method should determine whether the current cat (this) wins the fight or not, i.e. return true if the current cat wins and false if it loses.
If the fight is a draw and no one wins, then return false.

Requirements:

The Cat class must have only four fields: name, age, weight, and strength. The fields must be private.
The Cat class must have a fight method.
In the fight method, implement the mechanism for feline combat based on their weight, age, and strength in accordance with the task conditions.
The method should return the same value whenever the same cats fight.
If a certain cat1 wins over cat2, then cat2 must lose to cat1.
If there is a tie, then the fight method should return false.

package en.codegym.task.jdk13.task05.task0501; // CG TASK : "Cat carnage (3)" public class Solution { public static void main(String[] args) { Cat cat1 = new Cat("Al", 4, 8, 15); // COMPARING OBJECT STATES Cat cat2 = new Cat("Bo", 9, 10, 30); // ~~~~~~~~~~~~~~~~~~~~~~~ // OUTPUT Cat cat3 = new Cat("Ce", 12, 16, 20); System.out.println(cat1.fight(cat2)); // F System.out.println(cat2.fight(cat1)); // T System.out.println(cat2.fight(cat3)); // WHY IS THIS NOT FALSE??? <<< Where logic failed // F System.out.println(cat3.fight(cat2)); // -stronger = true See below... // T System.out.println(cat3.fight(cat1)); // -older = false // T System.out.println(cat1.fight(cat3)); // -fatter = false // F } public static class Cat { private String name; // INSTANCE VARIABLES private int age, weight, strength; //private boolean stronger, older, fatter = false; // Used to compare each stat separately. public Cat(String name, int age, int weight, int strength) { this.name = name; this.age = age; this.weight = weight; this.strength = strength; // CONSTRUCTOR } public boolean fight(Cat anotherCat) { int numOfBetterStats = 0; // Needed to quantify num of better stats. if (this.strength > anotherCat.strength) { numOfBetterStats++; //this.stronger = true; } if (this.age > anotherCat.age) { numOfBetterStats++; //this.older = true; } if (this.weight > anotherCat.weight) { numOfBetterStats++; //this.fatter = true; } boolean result = (numOfBetterStats > 1) ? true : false; return result; // if (this.stronger && this.fatter) return true; // <<< FLAWED LOGIC!!! // else if (this.fatter && this.older) return true; // Fails if there's not 2 "true"s. // else if (this.older && this.stronger) return true; // else return false; } //---------------------------------------------------------------------------------------------- // public boolean fight(Cat anotherCat) { // if (this.strength + this.age + this.weight == anotherCat.strength + anotherCat.age + anotherCat.weight) return false; // else if (this.strength + this.age + this.weight > anotherCat.strength + anotherCat.age + anotherCat.weight) { // //System.out.println("Win"); // return true; // } // else { // //System.out.println("Lose"); // return false; // } // } } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

8 February 2022, 17:54

This task really doesn't give a good explanation, or examples, of what the validation is testing, so it is hard to determine what may or may not be wrong with the above code. The only issue that I see is that this code will only declare a winner if 2 stats are clearly better in one cat than the other. Lets say any one or more of the three stats in the two "fighting" cats were the same then it would not be able to determine a winner. Example: cat1 = St: 5 - Age: 4 - Wgt: 8 cat2 = St: 5000 - Age: 4 - Wgt: 8 In this scenario it would seem, if Strength is looked upon as a good stat, that cat2 should be the winner; however the above code would not be able to determine that because both Age and Weight are the same in both cats. This is my theory with your code and I couldn't tell you if it correct or not.

Lisa

Level 41

8 February 2022, 17:57

that's the problem I see... I think they expect a winner if the other way round there is a loser

Cat cat1 = new Cat("Al", 3, 1, 2);
Cat cat2 = new Cat("Bo", 3, 2, 1);
System.out.println(cat1.fight(cat2));
System.out.println(cat2.fight(cat1));