Correct results but 4th and 5th conditions not met (Verificator bug?)

Question about the task

Under discussion

Hi, would you please check my code and advise why the last two conditions are not met? To me, it seems like a bug (?) Thank you.

Read a list of 20 words from the keyboard.
You need to count how many times each word appears in the list.
The result should be represented as a Map<String, Integer>, where the key is a unique word, and the value is the number of times the word appears in the list.

Display the contents of the map.
The case (uppercase/lowercase) affects the results.

Requirements:

The countWords method must declare and initialize a HashMap<String, Integer>.
The countWords method must return the created map.
The countWords method should add keys that correspond to unique words, and values that correspond to how many times those words occur.
The program should display the resulting map.
The main method must call the countWords method.

package com.codegym.task.task10.task1016; import java.io.BufferedReader; import java.io.InputStreamReader; import java.util.ArrayList; import java.util.HashMap; import java.util.Map; public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); ArrayList<String> words = new ArrayList<String>(); for (int i = 0; i < 20; i++) { words.add(reader.readLine()); } Map<String, Integer> map = countWords(words); for (Map.Entry<String, Integer> pair : map.entrySet()) { System.out.println(pair.getKey() + " " + pair.getValue()); } } public static Map<String, Integer> countWords(ArrayList<String> list) { HashMap<String, Integer> result = new HashMap<>(); for (int i = 0; i < list.size(); i++) { for (String key: list) { if (key.equals(list.get(i))) { } else { result.put(list.get(i),0); } } } for (String s : list) { result.replace(s, result.get(s), result.get(s)+1); } return result; } }

Comments (1)

Popular
New
Old

You must be signed in to leave a comment

Lisa

Level 41

11 February 2022, 16:37

Why CG is complaining... don't know. Could be the use of the replace method taking 3 arguments. You could try to remove the middle argument and retry to validate. Or validation has a hickup... then resetting the task may help. Another possibility would be, CG not only checks a 20 element list but also other sizes. Then your code would fail for a 1 element sized list. If that does not help, maybe it's a good idea to improve your code (make it also work for sizes 0 - x, at least my solution does and it validated) lines 27 - 35 are doing a lot of redundancy. The inner if-else executes 400 times just to get the keys from the list into the map. For that you'd just need lines 28 and 32 and could delete the rest. What I'd try: Loop over the list. For each element do the following Check if in map a ) no, put with value 1 b) yes, get the value, increment it, put with new value return map. When you get this running and are still motivated, then you can make this a two liner (even a one liner) with the getOrDefault method from the Map interface.