Is it error in my code or error with task? - java help on CodeGym

public class MinMaxUtil { public static int min = 0; public static int max = 0; public static int min(int a, int b){ return Math.min(a, b); } public static int min(int a, int b, int c){ if (a < b && a < c) min = a; if (b < a && b < c) min = b; if (c < a && c < b) min = c; return min; } public static int min(int a, int b, int c, int d) { if (a < b && a < c && a < d) min = a; if (b < a && b < c && b < d) min = b; if (c < a && c < b && c < d) min = c; if (d < a && d < b && d < c) min = d; return min; } public static int min(int a, int b, int c, int d, int e){ if (a < b && a < c && a < d && a < e) min = a; if (b < a && b < c && b < d && b < e) min = b; if (c < a && c < b && c < d && c < e) min = c; if (d < a && d < b && d < c && d < e) min = d; if (e < a && e < b && e < c && e < d) min = e; return min; } public static int max(int a, int b){ return Math.max(a, b); } public static int max(int a, int b, int c){ if (a > b && a > c) max = a; if (b > a && b > c) max = b; if (c > a && c > b) max = c; return max; } public static int max(int a, int b, int c, int d){ if (a > b && a > c && a > d) max = a; if (b > a && b > c && b > d) max = b; if (c > a && c > b && c > d) max = c; if (d > a && d > b && d > c) max = d; return max; } public static int max(int a, int b, int c, int d, int e){ if (a > b && a > c && a > d && a > e) max = a; if (b > a && b > c && b > d && b > e) max = b; if (c > a && c > b && c > d && c > e) max = c; if (d > a && d > b && d > c && d > e) max = d; if (e > a && e > b && e > c && e > d) max = e; return max; } } The max() methods should return the maximum of the passed numbers. - fail of this test

public static void main(String[] args) throws IOException { System.out.println(min(-1, 3)); System.out.println(min(-1, -2, -3)); System.out.println(max(7, 9, 2, 1, 115)); } public static int min(int a, int b) { return f(a, b); } public static int min(int a, int b, int c) { return f(a, b, c); } public static int max(int a, int b, int c, int d, int e) { return f(a, b, c, d, e); } // this is not a recommended way to code the min and max, just so you get the idea why to use varargs // better for sure would be to code two single purpose methods for each, minimum and maximum // ... and use a better identifier private static int f(int... num) { // some code return result; }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Thomas

Level 41 , Bayreuth, Germany

1 September 2022, 08:42

when you fixed your code you maybe want to try varargs to optimize it a little bit

Guadalupe Gagnon

Level 37 , Tampa, United States

31 August 2022, 20:10

The code doesn't work. When I add a main method and try:

System.out.println(min(4,4,4));

it should output 4 but instead outputs 0. Also if i try it with:

System.out.println(min(1,2,3));
System.out.println(min(3,3,3,3));

it should output: 1 3 but it outputs 1 1 The same problem I point out here is problematic in all but the min(a,b) and max(a,b) methods