CodeGym/Help with Java Tasks/Trying to validate printAdRevenue()

Level 41

Wilson

19.09.2022
407views
10comments

Trying to validate printAdRevenue()

Question about the task

Under discussion

I have been on this part for about 5 days and see no issue with the output. I have tried my code and others and am not certain what is going on for it to not pass. It appears the output is correct, totaling up the day's revenue and displaying it in descending order.

public Map<String, Long> getAdPerDayMap() {
        SimpleDateFormat dateFormat = new SimpleDateFormat("dd-MMM-yyyy", Locale.ENGLISH);
        List<EventDataRow> dataRows = statisticsStorage.storage.get(EventType.VIDEOS_SELECTED);
        Map<String, Long> revenueByDay = new TreeMap<>(Comparator.reverseOrder());
        dataRows.forEach((dataRow -> {
            dayOfTheMonth++;
            String currDay = dateFormat.format(dataRow.getDate());
            long amount = ((VideosSelectedEventDataRow) dataRow).getAmount();
            revenueByDay.put(currDay, revenueByDay.getOrDefault(currDay, 0L) + amount);
        }));
        return revenueByDay;
    }

public void printAdRevenue() {
        Map<String, Long> adRevenuePerDay = StatisticsManager.getInstance().getAdPerDayMap();
        adRevenuePerDay.forEach((key, value) -> {
            totalRevenuePerDay += value;
            ConsoleHelper.writeMessage(String.format(Locale.ENGLISH, "%s - %.2f", key, value / 100.0));
        });
        ConsoleHelper.writeMessage(String.format(Locale.ENGLISH, "Total - %.2f", totalRevenuePerDay / 100.0));
    }

Let's implement the first statistics item: advertising revenues, grouped by day.

1. In the VideosSelectedEventDataRow class, create a getter for the amount field.
In the OrderReadyEventDataRow class, create a getter for the cookName field.

2. In StatisticsManager, create a method (come up with its name on your own) that will get all repository data related to displaying advertising, and will calculate the total revenues for each day.
Additionally, add a get helper method to the repository class to access the data.

3. Let's start with the logic of the printAdRevenue method in the ManagerTablet class.
Using the method from the previous item, display the dates and amounts in decreasing order.
For each date with displayed ads in the event repository, the revenue per impression for that date should be displayed.
At the end, display "Total" and the total amount.

Example:

14-May-2013 - 2.50
13-May-2013 - 1.02
12-May-2013 - 543.98
Total - 547.50

4. Let's implement the second statistics item: cook utilization (time spent working), grouped by day.

In StatisticsManager, create a method (come up with its name on your own) that will get all repository data related to a cook's work, and will calculate the total time spent working for each cook separately.

5. Implement the logic of the ManagerTablet class's printCookUtilization method.
Using the method from the previous item to display dates, names of cooks, and hours worked (round up), in decreasing order.
For each date in the event repository with a record about work performed by a cook, the time worked on that date in minutes should be displayed.
If a cook did not work on a day, then DO NOT display empty data for him or her (see 13-May-2013)
Sort the cooks by name

Example:

14-May-2013
Puck - 60 min
Ramsay - 35 min

13-May-2013
Puck - 129 min

12-May-2013
Puck - 6 min
Ramsay - 5 min

Requirements:

A getter for the amount field must be created in the VideosSelectedEventDataRow class.
A getter for the cookName field must be created in the OrderReadyEventDataRow class.
The ManagerTablet class's printAdRevenue method must be implemented in accordance with the task conditions.
The ManagerTablet class's printCookUtilization method must be implemented in accordance with the task conditions.

package com.codegym.task.task27.task2712; import com.codegym.task.task27.task2712.statistics.StatisticsManager; import java.text.DateFormat; import java.text.SimpleDateFormat; import java.util.*; public class Test { private long totalAdRevenue = 0; static public TreeMap<Date, Long> getDailyRevenues() { TreeMap<Date, Long> dailyRevenues = new TreeMap<>(Comparator.reverseOrder()); dailyRevenues.put(new Date("Jul 12 12:23:07 EDT 2022"), 10l); dailyRevenues.put(new Date("Jul 12 11:23:07 EDT 2022"), 100l); dailyRevenues.put(new Date("Jul 12 10:23:07 EDT 2022"), 50l); dailyRevenues.put(new Date("Jul 13 12:23:07 EDT 2022"), 5l); dailyRevenues.put(new Date("Jul 13 11:23:07 EDT 2022"), 20l); dailyRevenues.put(new Date("Jul 13 10:23:07 EDT 2022"), 30l); dailyRevenues.put(new Date("Jul 14 12:23:07 EDT 2022"), 1000l); dailyRevenues.put(new Date("Jul 14 11:23:07 EDT 2022"), 70l); dailyRevenues.put(new Date("Jul 14 10:23:07 EDT 2022"), 15l); return dailyRevenues; } public static void main(String[] args) { // TreeMap<Date, Long> dailyRevenue = getDailyRevenues(); // double revenueAsDouble; // double sumRevenue = 0; // DateFormat df = new SimpleDateFormat("dd-MMM-yyyy"); // for (Map.Entry<Date, Long> dateWithRevenue : dailyRevenue.entrySet()) { // revenueAsDouble = ((double) dateWithRevenue.getValue()) / 100; // sumRevenue += revenueAsDouble; // System.out.println(df.format(dateWithRevenue.getKey()) + " - " + String.format("%.2f", revenueAsDouble)); // } // System.out.println("Total - " + String.format("%.2f", sumRevenue)); // System.out.println(); System.out.printf(Locale.ENGLISH, "%.2f", 11000/100.0); } }

Comments (10)

Popular
New
Old

You must be signed in to leave a comment

Level 41 , Wilson, United States

23 September 2022, 12:19

I passed this after 70 attempts but not because I didn't understand it. The validator was saying everything was fine aside from the printAdRevenue() method even when my printAdRevenue() method was exactly like someone else's who had passed so I went and eventually copied someone else's code that was passing everything but the printAdRevenue() and then fixed that method and it passed. It seems the validator wasn't passing due to some other code or how the other code was written and not the method that was failing itself. In short, you may have to change previous code even though it passed earlier, if you find that your code isn't passing and you think it should be.

Guadalupe Gagnon

Level 37 , Tampa, United States

19 September 2022, 14:23

#2 The printAdRevenue() method is a little wrong. Try implementing these changes I made between lines 13-18 to test the code and run it:

public static void printAdRevenue() throws Exception {
        HashMap<Date, Long> dailyRevenue = new HashMap<>();
        DateFormat df = new SimpleDateFormat("dd-MMM-YYYY", Locale.ENGLISH);
        dailyRevenue.put(df.parse("14-May-2013"), 250l);
        dailyRevenue.put(df.parse("13-May-2013"), 102l);
        dailyRevenue.put(df.parse("12-May-2013 "), 543l);
        System.out.println(dailyRevenue);


        //StatisticsManager statisticsManager = StatisticsManager.getInstance();
        //TreeMap<Date, Long> dailyRevenue = statisticsManager.getDailyRevenues();
        double revenueAsDouble;
        double totalSumRevenue = 0;
        //DateFormat df = new SimpleDateFormat("dd-MMM-YYYY");
        TreeMap<String, Double> dailySum = new TreeMap<>(Comparator.reverseOrder());

Guadalupe Gagnon

Level 37 , Tampa, United States

19 September 2022, 14:25

It is only printing the total of the last entry. When I print the date that it is stored as I am getting: Sun Dec 30 00:00:00 EST 2012 **hint** YYYY is not the correct format

Guadalupe Gagnon

Level 37 , Tampa, United States

19 September 2022, 14:26

Also. It should be printing each day, but it only prints the total.

Guadalupe Gagnon

Level 37 , Tampa, United States

19 September 2022, 14:04

#1 StatisticsManager - lines 64-70: The getDate() method is going to return the full date with month-day-year-seconds-minutes-hours. This is going to be a problem because a new entry will be added for each unique date value. You are going to want to get rid of the time information and store it specifically as month-day-year only. tip: lines 55-61 (of statistics manager) can be simplified to either:

return -o1.compareTo(o2);

// - OR -

return o2.compareTo(o1);

Guadalupe Gagnon

Level 37 , Tampa, United States

19 September 2022, 14:11

I see you actually did the above in the ManagerTablet class. The task does say that it should be by day in the StatisticsManager class. I am still looking through the code for anything else I can comment on.

Level 41 , Wilson, United States

19 September 2022, 14:23

Much appreciated. In the getAdPerDay() method, it takes all those dates and converts them to the format of "dd-MMM-yyyy" and I can then see using the debugger that it totals up both those entries under the same dates and adds them together.

Guadalupe Gagnon

Level 37 , Tampa, United States

19 September 2022, 14:27

This may or may not be a problem. There is a problem in the printAdRev() method that will 100% need to be fixed.

Level 41 , Wilson, United States

19 September 2022, 14:32

I think I know what you're referring to. Let me check that.

Level 41 , Wilson, United States

19 September 2022, 16:16

For whoever may come by this, my dates were not ordering via the dates but were ordered via the Strings so they weren't in proper order. I used a comparator to put them in proper order and they're now aligned how they should be and descending but I'm still not passing thus far for the printAdRevenue() method.