It seems to be good solution

Question about the task

Find all the files

Java Collections, Level 1, Lesson 2

Under discussion

need hint

Implement the getFileTree method, which must create a list of all of the files, including nested files.
Don't use recursion.
Return a list of the paths to all the found files. Don't return paths to directories.
The path must be absolute.

Requirements:

The getFileTree method must accept a String root as an argument. It indicates the folder where you need to find all nested files.
The getFileTree method must return a list of Strings.
You need to implement the getFileTree method: find all the files in the specified path and add them to the list.
The getFileTree method must only be called once (don't use recursion).

package com.codegym.task.task31.task3102; import java.io.File; import java.io.IOException; import java.lang.reflect.Array; import java.nio.file.Files; import java.nio.file.Paths; import java.util.ArrayList; import java.util.List; import java.util.PriorityQueue; import java.util.Queue; import java.util.stream.Collectors; /* Find all the files */ public class Solution { public static List<String> getFileTree(String root) throws IOException { ArrayList<String> list = new ArrayList<>(); File f = new File(root); for (File temp : f.listFiles()){ String x = temp.getAbsolutePath(); list.add(x); } return list; } public static void main(String[] args) { } }

Comments (7)

Popular
New
Old

You must be signed in to leave a comment

Franek

Level 29 , Torun, Poland

4 June 2019, 13:10

Read about Files.walk

Ewerton Backend Developer

8 July 2019, 02:07

Thank, one-line solution. But I really prefer using recursion

Csaba Gódor

Level 36 , Budapest, Hungary

15 January 2020, 14:11

public static List<String> getFileTree(String root) throws IOException {
        List<String> result = null;
        try (Stream<Path> walk = Files.walk(Paths.get(root))){
           result = walk.filter(Files::isRegularFile).map(Path::toString).collect(Collectors.toList());
        }
        return result;
    }

is passed, tutorial is here https://mkyong.com/java/java-files-walk-examples/ , thanks

Wojtek

Level 23 , Solec-Zdroj

17 April 2019, 11:12

anyone solved it?

Djole

Level 41 , Belgrade, Serbia

21 April 2019, 17:24

It says you need to use queue to get all the files from directory and subdirectories (nested files). Your list is lacking nested files.

Ian De Bie Full Stack Developer

23 November 2020, 21:09

i solved it with this solution. specifically states to not use recursion.

public static List<String> getFileTree(String root) throws IOException {
    List<String> fileTree = new ArrayList<>();
    Deque<File> folders = new ArrayDeque<>();
    folders.offer(new File(root));
    while (!folders.isEmpty()) {
        File folder = folders.poll();
        for (File file : Objects.requireNonNull(folder.listFiles())) {
            if (file.isFile()) fileTree.add(file.getAbsolutePath());
            if (file.isDirectory()) folders.add(file);
        }
    }
    return fileTree;
}

Andrei

Level 41

11 June 2021, 13:17

Yours looks better than the one the mentor displays. It's less code anyway.