Please advise on the issue below

Question about the task

Under discussion

The below failure message is shown: The printList method should display each element of the passed list on a new line. The program should display the three supplementary lists using the printList method.

1. Enter 20 numbers from the keyboard, save them in a list, and then sort them to three other lists:
Numbers divisible by 3 (x%3==0), numbers divisible by 2 (x%2==0), and all other numbers.
Numbers simultaneously divisible by 3 and 2 (for example 6) go into both lists.
The order in which the lists are declared is very important.
2. The printList method should display each list item on a new line.
3. Using the printList method, display these three lists. First, the list for x%3, then the list for x%2, and then the last list.

Requirements:

Declare and immediately initialize 4 ArrayList<Integer> variables. The first list will be the main one. The other lists will be supplementary.
Read 20 numbers from the keyboard and add them to the main list.
Add to the first supplementary list all numbers in the main list that are divisible by 3.
Add to the second supplementary list all numbers in the main list that are divisible by 2.
Add to the third supplementary list all the remaining numbers from the main list.
The printList method should display each element of the passed list on a new line.
The program should display the three supplementary lists using the printList method.

package com.codegym.task.task07.task0713; import java.io.BufferedReader; import java.io.InputStreamReader; import java.util.ArrayList; import java.util.List; /* Playing Javarella */ public class Solution { public static void main(String[] args) throws Exception { //write your code here BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); ArrayList<Integer> list = new ArrayList<Integer>(); for(int i = 0; i<20; i++){ int p = Integer.parseInt(reader.readLine()); list.add(p); } printList(list); } public static void printList(List<Integer> list) { //write your code here ArrayList<Integer> list3 = new ArrayList<Integer>(); ArrayList<Integer> list2 = new ArrayList<Integer>(); ArrayList<Integer> list1 = new ArrayList<Integer>(); int q; for(Integer x : list){ if(x%3==0) list3.add(x); if(x%2==0) list2.add(x); if(x%3==0 || x%2==0) q =0; //Skip this line else list1.add(x); } for(Integer x : list){ System.out.println(x); } for(Integer x : list3){ System.out.println(x); } for(Integer x : list2){ System.out.println(x); } for(Integer x : list1){ System.out.println(x); } } }

Comments (1)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

22 April 2019, 13:32

You wrote your entire task in the printList method where the only thing the printList method should do is output any list passed to it. Pretty much what lines 49-51, or 57-59, or 61-63 do (but not all three). Take all the code you wrote from line 30-47 out of that method and put it either in main, or make your own method, then delete 2 of the output lines and refactor the last one to output the list passed in. The code should look like this:

psvm(String[] args){
    //create list, listMod3, listMod2, listNot
    // get 20 number from user, enter them in list
    // either sort the list into 3 sub lists here, or make your own method
    printList(listMod3);
    printList(listMod2);
    printList(listNot);
}

public static void printList(List<Integer> list){
   for(Integer x : list){
      System.out.println(x);
   }
}

Also there is no need for int q, line 43 - just write it like this:

if(x % 3 != 0 && x % 2 != 0)
   list1.add(x);