Compiled, Tested with manual entries. Work for me but not for CodeGym. Review please ?

Question about the task

Resolved

Hey Guys, Everything look fine with this code, i tried manual entries (like ascendant, descendant sets with violators and some with not). I dont know why i don't pass the test in codegym. Someone here for a code review please ?

ArrayList<String> list = new ArrayList<>();

        BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
        for (int i = 0; i < 10; i++) {
            list.add(reader.readLine());
        }

        ArrayList<Integer> violators = new ArrayList<>();

        int type = Integer.MAX_VALUE;
        if (list.get(1).compareTo(list.get(0)) > 0) {
            type = 1;
        } else {
            type = 2;
        }   // Type 1 = Ascendant  and Type2 = Descendant


        for (int i = 1; i < list.size(); i++) {
            String current = list.get(i);
            String previous = list.get(i - 1);
            if (type == 1 && current.compareTo(previous) < 0) {
                violators.add(i);
            }
            if (type == 2 && current.compareTo(previous) > 0) {
                violators.add(i);
            }
        }
        if (!violators.isEmpty()) {
            System.out.println(violators.get(0));
        }

Happy Coding !

1. Read 10 words from the keyboard and add them to a list of strings.
2. Determine whether the list is ordered by increasing string length.
3. If it is not, then display the index of the first element that violates this order.

Requirements:

Declare a string list variable and immediately initialize it.
Read 10 lines from the keyboard and add them to the list.
If the list is ordered by increasing string length, then you don't need to display anything.
If the list is not ordered by increasing string length, then display the index of the first element that violates this order.

package com.codegym.task.task07.task0718; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.ArrayList; /* Checking the order */ public class Solution { public static void main(String[] args) throws IOException { ArrayList<String> list = new ArrayList<>(); BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); for (int i = 0; i < 10; i++) { list.add(reader.readLine()); } ArrayList<Integer> violators = new ArrayList<>(); int type = Integer.MAX_VALUE; if (list.get(1).compareTo(list.get(0)) > 0) { type = 1; } else { type = 2; } // Type 1 = Ascendant and Type2 = Descendant for (int i = 1; i < list.size(); i++) { String current = list.get(i); String previous = list.get(i - 1); if (type == 1 && current.compareTo(previous) < 0) { violators.add(i); } if (type == 2 && current.compareTo(previous) > 0) { violators.add(i); } } if (!violators.isEmpty()) { System.out.println(violators.get(0)); } } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Julien

Level 15 , Paris, France

11 May 2019, 21:02

Oh my wow, i really need to sleep ! Thank you <3

Guadalupe Gagnon

Level 37 , Tampa, United States

11 May 2019, 21:07

I have a suggestion. Change the list from String type to Integer type. Then at line 19 change it to:

list.add(reader.readline().length())

Now you can use almost all your code, just change to check only for ascending lengths, and you only need to print the index of the first violator. This would help instead of starting over.

Guadalupe Gagnon

Level 37 , Tampa, United States

11 May 2019, 20:59

solution

#1 The compareTo method is checking alphabetical order of the strings and not string lengths #2 you shouldn't be concerned with descending, the requirements only want you to check for ascending string LENGTH order #3 you don't need to create a list of violators, that is too much work being done after you find the answer. Just print the first occurrence and break the loop when it is found.