Can't pass second condition.

Question about the task

GCD

Java Core, Level 4, Lesson 8

Under discussion

package com.codegym.task.task14.task1420; /* GCD */ import java.io.*; public class Solution { public static void main(String[] args) throws Exception { try { BufferedReader reader= new BufferedReader(new InputStreamReader(System.in)); int num1 = Integer.parseInt(reader.readLine()); int num2 = Integer.parseInt(reader.readLine()); if(num1 <= 0 || num2 <= 0) throw new NumberFormatException("dsfgsd"); reader.close(); int dividend; int divisor; if(num1 > num2) { dividend = num1; divisor = num2; } else { dividend = num2; divisor = num1; } for(int n = divisor; n > 0; n--) { if(dividend%n == 0 && divisor%n == 0) { System.out.println(n); break; } } } catch (NumberFormatException e) { e.printStackTrace(); } } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Henk

Level 19 , Pretoria, South-Africa

20 May 2019, 13:22

This worked (I call my own method, which divides and returns the GCD), but check underneath: the second piece of code did not work. Also had to remove the Try & Catch block. Worked: BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int a = Integer.parseInt(reader.readLine()); if (a < 0) throw new Exception("Input is not a positive Int"); int b = Integer.parseInt(reader.readLine()); if (b < 0) throw new Exception("Input is not a positive Int"); System.out.println(DivideThem(a,b)); } DID NOT WORK: BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); try{ int a = Integer.parseInt(reader.readLine()); if (a < 0) throw new Exception("Input is not a positive Int"); int b = Integer.parseInt(reader.readLine()); if (b < 0) throw new Exception("Input is not a positive Int"); System.out.println(DivideThem(a,b)); } catch (Exception e){ }

Guadalupe Gagnon

Level 37 , Tampa, United States

12 May 2019, 17:30

useful

Try a couple of things: #1 check if the number is positive after each entry and throw an exception instead of after both inputs. #2 change the conditions from <= to just < Then mix and match these two. one or a combination of these should see you through. Please share what the verification finally accepted.

SilverZax

Level 18 , Poltava, Ukraine

13 May 2019, 09:53

Thanks for your help! I passed condition, when i removed try-catch block.

public class Solution {
    public static void main(String[] args) throws Exception {
            Scanner scanner = new Scanner(System.in);
            int num1 = scanner.nextInt();
            if(num1 <= 0) throw new NumberFormatException("Number must be positive");
            int num2 = scanner.nextInt();
            if(num2 <= 0) throw new NumberFormatException("Number must be positive");

            int dividend;
            int divisor;
            if(num1 > num2) {
                dividend = num1;
                divisor = num2;
            } else {
                dividend = num2;
                divisor = num1;
            }
            for(int n = divisor; n > 0; n--) {
                if(dividend%n == 0 && divisor%n == 0) {
                    System.out.println(n);
                    break;
                }
            }
    }
}