Im pretty sure the code works correctly

Question about the task

Task about algorithms

Java Syntax, Level 5, Lesson 12

Archived

Can anyone tell me what is wrong here?

Write a program that:
1. reads a number N (must be greater than 0) from the console
2. reads N numbers from the console
3. Displays the maximum of the N entered numbers.

Requirements:

The program should read the numbers from the keyboard.
The program must display a number on the screen.
The class must have a public static void main method.
Don't add new methods to the Solution class.
The program should display the maximum of the N entered numbers.
The program should not display anything if N is less than or equal to 0.

package com.codegym.task.task05.task0532; import java.io.*; import java.util.Scanner; /* Task about algorithms */ public class Solution { public static void main(String[] args) throws Exception { Scanner sc = new Scanner(System.in); int maximum = 0; int total = sc.nextInt(); int[] numbers = new int[total]; //write your code here for (int i = 0 ; i < total ; i ++){ numbers[i] = sc.nextInt(); } for (int i = 0 ; i < total ; i ++){ if (numbers[i] > maximum){ maximum = numbers[i]; } } System.out.println(maximum); } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

P.B.Kalyan Krishna

Level 22 , Guntur, India

26 May 2019, 09:05

You have set the maximum value as 0. But you have declared the array as an integer array. What if the elements contain all negative values? There are many ways to do this problem. Personally, I like one approach. Set the first value in the array as 'maximum'. Now compare each value of the array with this maximum and whichever element is greater than maximum, will be the new 'maximum'. See the code below:- maximum = numbers[0]; for(int i =1;i < total; i++) { if(numbers[i] > maximum) maximum = numbers[i]; } System.out.println("The maximum number = "+maximum); We have set the first element of the array as the maximum element. And we compared all the remaining elements with this maximum. Whichever number is greater than this number will be set as the new maximum. Hope this helps.

Guadalupe Gagnon

Level 37 , Tampa, United States

20 May 2019, 15:45

You set maximum to 0. This is never a good idea because you are assuming that the entered numbers will be greater than 0. What if the user, after N of course, enter all negative numbers? This code will output 0. In your code you can fix this by either doing: 1) Set maximum to the lowest possible value of an integer. The Integer class has a predefined tag for this so you do not need to remember what that value is: Integer.MIN_VALUE or 2) set maximum to numbers[0] before the loop at line 23. You can then start the loop at 1 instead of 0: for(int i = 1; i < total; i++)

Halmstark

Level 6 , Warsaw, Poland

20 May 2019, 16:19

Woah, I actually didn't know yet that the predefined tag Integer.MIN_VALUE exists. Now that i have read something about it, it all make sense. Also, changed maximum from 0 to numbers[0] since it enabled the values to store negative numbers and this way it felt more natural to me. Worked like a charm. Thanks bro for putting your time and have a nice day.

Guadalupe Gagnon

Level 37 , Tampa, United States

20 May 2019, 16:39

No problem! Keep at it, you will start getting better and better the more you practice and learn. Java is a HUGE language though and you will be introduced to new concepts all through the levels. My biggest advice is to take a break, if/when you need to, before you burn out; but don't give up.