a question

Question about the task

Under discussion

package com.codegym.task.task07.task0711;

import java.io.BufferedReader;
import java.io.InputStreamReader;
import java.util.ArrayList;

/*
Remove and insert

*/

public class Solution {
    public static void main(String[] args) throws Exception {
        //write your code here
        ArrayList<String> strings = new ArrayList<String>();
        BufferedReader buffer = new BufferedReader(new InputStreamReader(System.in));

        for(int i=0;i<5;i++){
            strings.add(buffer.readLine());
            if(i==4){
                for(int j=0;j<13;j++){
                    int last = strings.size()-1;
                    strings.add(0,strings.get(last));
                    strings.remove(last);
                }
            }
        }

        for(int i=0;i<strings.size();i++){
                System.out.println(strings.get(i));
        }
    }
}

package com.codegym.task.task07.task0711; import java.io.BufferedReader; import java.io.InputStreamReader; import java.util.ArrayList; /* Remove and insert */ public class Solution { public static void main(String[] args) throws Exception { //write your code here ArrayList<String> strings = new ArrayList<String>(); BufferedReader buffer = new BufferedReader(new InputStreamReader(System.in)); for(int i=0;i<5;i++){ strings.add(buffer.readLine()); if(i==4){ for(int j=0;j<13;j++){ int last = strings.size()-1; strings.add(0,strings.get(last)); strings.remove(last); } } } for(int i=0;i<strings.size();i++){ System.out.println(strings.get(i)); } } }

Comments (7)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

21 May 2019, 15:31

First, move the loop at line 21 outside of the loop at line 18. I see that you have that loop only run at the last iteration of the outer loop, but that is 4 boolean checks (line 20) that are unnecessary and slow your code down (granted in this code less than a millisecond, but still unnecessary). Second, the loop at line 21 does this: gets the index number of the last string of a list that is length of 5, last, which will store 4 adds to the list, at the very first index, the string that is at index last (the list is now length 6) removes from the list the index last (which is equal to 4) instead of the last index of the current list of size 6.

dean

Level 8 , Deutschland, Germany

21 May 2019, 16:05

i still dont get what's wrong.. it takes index 4 and remove and assign it and then re loop and adjust the index accordingly.. they asked to add and remove so where's my problem? thanks

Guadalupe Gagnon

Level 37 , Tampa, United States

21 May 2019, 16:59

nope. Lets say that you have an array like this: [one, two, three, four, five] - Line 22 will set the int to 4 - Line 23 adds the word five to the front of the list, the list is now: [five, one, two, three, four, five] - line 24 will remove the 4th index from the list, which now is the value four. The list will be: [five, one, two, three, five] You repeat this 13 times and your final list will be: [five, five, five, five, five]

dean

Level 8 , Deutschland, Germany

21 May 2019, 17:22

yes that's what i wanted to do because it literally says: Remove the last string and insert it at the beginning. Rinse and repeat 13 times. so it always stay 5 elements then.. what in the requimenet i didnt get? thanks

Guadalupe Gagnon

Level 37 , Tampa, United States

21 May 2019, 17:29

=P if that is what you were trying to do then good job!! The requirements want you to do this though: [one, two, three, four, five] 1 - [five,one,two,three,four] 2 - [four, five, one, two, three] 3 - [three, four, five, one, two] ...... and ten more times

dean

Level 8 , Deutschland, Germany

21 May 2019, 17:37

thanks that what i was missing.. the insturctions were unclear, now i've passed it smoothly :) just had to save another var for the value, thanks a ton buddy for such quick and informative replies without giving the solutions directly! :) appericate it!

dean

Level 8 , Deutschland, Germany

21 May 2019, 17:39

also i remember you said don't use the for loop of if i==4 inside the other for loop, why it's not good practice? i thought it makes the program shorter as i stack it all in one main for loop instead of 2 seperated ones? so why isnt it better? just curious thanks )