Failing test even though it matches task conditions. Why?

Question about the task

Resolved

I've run and tested this code over and over and it seems to me to match the task conditions, however its not passing the tests? Does anyone know why?

Use the keyboard to enter a positive number. Determine the number of even digits and odd digits in the entered number.
If a number is divisible by 2 without a remainder (i.e. the remainder is zero), then it is even.
And we'll increase the even digit counter (static variable even) by 1.
Otherwise, the number is odd, so we'll increase the odd digit counter (static variable odd).
Display the following message: "Even: a Odd: b", where a is the number of even digits and b is the number of odd digits.

Example for 4445:
Even: 3 Odd: 1

Requirements:

The program must read data from the keyboard.
The main method should calculate how many even digits are in the entered number and then write this number to the variable even.
The main method should calculate how many odd digits are in the entered number and then write this number to the variable odd.
The program should display text on the screen.
The displayed text must match the task conditions.

package com.codegym.task.task06.task0606; import java.io.*; /* Even and odd digits */ public class Solution { public static int even; public static int odd; public static void main(String[] args) throws IOException { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int n = Integer.parseInt(reader.readLine()); if (n < 0) n *= -1; for (int i = 1; i < n; i *= 10) { int m = n / i; if (m % 2 == 0) even++; else odd++; } System.out.printf("Even: %d Odd: %d", even, odd); } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

ThomasLC

Level 16 , Singapore, Singapore

22 May 2019, 17:33

Guadalupe is right, some times the codegym verification has some not obvious or condition that is not mentioned that affects it. He is giving you 3 options to change it to a print output that also inserts a new line. I took a look at my solution and I was using " System.out.println("Even: "+even+"Odd: "+odd); " so that may very well be the issue

Guadalupe Gagnon

Level 37 , Tampa, United States

22 May 2019, 14:32

Change your output to: System.out.printf("Even: %d Odd: %d\n", even, odd); if that doesn't work, try this: System.out.println(String.format("Even: %d Odd: %d", even, odd)); and last, if the above methods don't work: System.out.println("Even: " + even + " Odd: " + odd);

Brandon

Level 7 , Houston, United States

23 May 2019, 12:32

None of these worked, however I may have found the problem but don't know how to fix it. If the input is a multiple of 10, like 1000, it doesn't count the 1. It would say 3 even and 0 odd.

Brandon

Level 7 , Houston, United States

23 May 2019, 12:42

solution

Nevermind I fixed it by simply changing the loop to be i<=n instead of i<n

Guadalupe Gagnon

Level 37 , Tampa, United States

23 May 2019, 13:34

good catch. I didn't even notice that. I'll share to you just a slightly more efficient way:

while(n != 0){
   if(n % 2) // determine even or odd to increment
   n /= 10;
}

I kept the mod part very abstract, but you can figure out how to implement it. In this code negative numbers work the same as positive, so you wouldn't need to check for negative first. While loops actually run faster than for loops. I almost always try to use a while loop when i don't need a 0-max counter.