Bugged!

Question about the task

Log parser (part 1)

Java Collections, Level 7, Lesson 15

Under discussion

Validation of Condition 6 is bugged. Or description of condition is not correct.

Today we're going to write a log parser.

The log file has the following format:
ip username date event status

where:
ip is the IP address from which the user generated the event,
user is the username (one or more words separated by spaces),
date is the date of the event formatted as <day.month.year hour:minute:second>,
event is one of the following events:
LOGIN - a user logged in,
DOWNLOAD_PLUGIN - a user downloaded the plugin,
SEND_MESSAGE - a user sent a message,
ATTEMPT_TASK - a user attempted to complete a task,
COMPLETE_TASK - a user has completed a task.
The ATTEMPT_TASK and COMPLETE_TASK events have one additional parameter, separated from the others by a space: the task number.
status is one of the following event statuses:
OK - the event succeeded,
FAILED - the event failed,
ERROR - an error occurred.

Example of a line from a log file:
"146.34.15.5 Eduard Bentley 05.01.2021 20:22:55 COMPLETE_TASK 48 FAILED".
The log file entries are not necessarily ordered by date: events could be logged in a different order than they occur.

The class that will be responsible for parsing logs is called LogParser.
1.1. Add a LogParser class constructor with a Path logDir parameter that indicates the directory with the logs. There may be several logs. All of them must have the LOG extension.
1.2. Implement the IPQuery interface in the LogParser class:
1.2.1. The getNumberOfUniqueIPs(Date after, Date before) method should return the number of unique IP addresses for the specified period. Hereinafter, if a method has Date after and Date before parameters, then you should only return data related to this period (including the dates represented by the after and before parameters).
If the after parameter is null, then you need to process all entries whose date is less than or equal to the before parameter.
If the before parameter is null, then you need to process all entries whose date is greater than or equal to the after parameter.
If both after and before are null, then you need to process absolutely every entry (without filtering by date).
1.2.2. The getUniqueIPs() method must return a set of all unique IP address. Store each IP address in a String.
1.2.3. The getIPsForUser() method must return the IP addresses that the passed user has worked from.
1.2.4. The getIPsForEvent() method must return the IP addresses that produced the passed event.
1.2.5. The getIPsForStatus() method must return the IP addresses that generated events that ended with the passed status.

You can change the implementation of the main() method as you see fit.

Requirements:

A public LogParser(Path logDir) constructor must be created in the LogParser class.
The LogParser class must support the IPQuery interface.
The getNumberOfUniqueIPs(Date, Date) method should return the number of unique IP addresses for the specified period.
The LogParser class's getUniqueIPs(Date, Date) method must return a set containing all unique IP addresses for the specified period.
The LogParser class's getIPsForUser(String, Date, Date) method must return the IP addresses that the passed user worked from during the specified period.
The LogParser class's getIPsForEvent(Event, Date, Date) method must return the IP addresses that generated the passed event during the specified period.
The LogParser class's getIPsForStatus(Status, Date, Date) method must return the IP addresses that generated events that ended with the specified status during the specified period.

package com.codegym.task.task39.task3913; import java.nio.file.Paths; import java.util.Date; public class Solution { public static void main(String[] args) { LogParser logParser = new LogParser(Paths.get("d:/logs")); System.out.println(logParser.getNumberOfUniqueIPs(null, null)); logParser.prinEntries(null, null); System.out.println("\n------------------------------------------\n"); logParser.prinEntries(null, new Date()); System.out.println("\n------------------------------------------\n"); logParser.prinEntries(new Date(), null); System.out.println("\n------------------------------------------\n"); logParser.prinEntries(new Date(), new Date()); System.out.println("\n------------------------------------------\n"); System.out.println(logParser.getIPsForStatus(Status.OK, null, null)); System.out.println(logParser.getIPsForEvent(Event.ATTEMPT_TASK, null, null)); } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Justin Smith

Level 41 , Greenfield, USA, United States

13 February 2023, 23:30

My code is very different from yours but I am also having the problem that only getIPsForEvent fails but the others, which operate in very similar ways, pass.

Thomas

Level 41 , Bayreuth, Germany

14 February 2023, 09:37

I have written similar methods for all required variations and that worked without a problem

// start IPQuery methods +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
@Override
public int getNumberOfUniqueIPs(Date after, Date before) {
    return getUniqueIPs(after, before).size();
}

@Override
public Set<String> getUniqueIPs(Date after, Date before) {
    return logStream(after, before)
            .map(entry -> entry.ip)
            .collect(Collectors.toSet());
}

@Override
public Set<String> getIPsForUser(String user, Date after, Date before) {
    return getIPsForFilter(entry -> entry.name.equals(user), after, before);
}

@Override
public Set<String> getIPsForEvent(Event event, Date after, Date before) {
    return getIPsForFilter(entry -> entry.event == event, after, before);
}

@Override
public Set<String> getIPsForStatus(Status status, Date after, Date before) {
    return getIPsForFilter(entry -> entry.status == status, after, before);
}
// end IPQuery methods +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Thomas

Level 41 , Bayreuth, Germany

14 February 2023, 09:40

helper methods

// applies the IP filter to the stream
public Set<String> getIPsForFilter(Predicate<Entry> filter, Date after, Date before) {
    return logStream(after, before)
            .filter(filter)
            .map(entry -> entry.ip)
            .collect(Collectors.toSet());
}

// checks if current is in the range of after to before (after is the < Date, before the > Date)
private boolean isInDateRange(Date current, Date after, Date before) {
    if (after == null)
        after = new Date(Long.MIN_VALUE);
    if (before == null)
        before = new Date(Long.MAX_VALUE);

    return current.after(after) && current.before(before);
}

// creates a stream filtered by isInDateRange
private Stream<Entry> logStream(Date after, Date before) {
    return logs.stream()
            .filter(entry -> isInDateRange(entry.date, after, before));
}

季军

Level 38 , Shanghai, China

28 August 2019, 13:20

The date format should be "dd.MM.yyyy HH:mm:ss", because hh is used for 12 hour, HH is 24 hour

+10