Not sure where I'm going wrong

Question about the task

Archiver (part 10)

Java Multithreading, Level 7, Lesson 15

Resolved

ZipFileManager class. Help please!

It's time to refactor the ZipFileManager class. The createZip method has code that we're also going to need in the methods that will add files to or remove them from an archive, extract files, etc. We'll implement those methods later, but we can move the common code to separate methods now.
Additionally, the createZip method can only create an archive from a single file, but we would like to be able to zip an entire folder. We won't create a separate method for this, since you can pass both a directory and a regular file to the createZip(Path source) method.

Today's tasks:
1. Implement a private void addNewZipEntry(ZipOutputStream zipOutputStream, Path filePath, Path fileName) throws Exception method in the ZipFileManager class.
It must:
1.1. Create an InputStream for the file named fileName located in the filePath directory
1.2. Create a new ZipEntry, using fileName as the name after converting it to a String
1.3. Copy the data from the InputStream (from step 1.1) to the zipOutputStream parameter
1.4. Close the zip entry
1.5. Close the InputStream using try-with-resources
2. Replace part of the createZip method's code with a call to the addNewZipEntry method. Pass source.getParent() as the filePath parameter, and source.getFileName() as the filename.
3. Implement a private void copyData(InputStream in, OutputStream out) throws Exception method. It must read data from "in" and write to "out", until it reads through everything.
4. Replace part of the addNewZipEntry method's code with a call to the copyData method.
5. Let's return to createZip:
5.1. At the beginning of the method, check to see if the directory (zipFile.getParent()) where we will create zipFile exists; if not, then create it.
5.2. If source is a regular file (use Files.isRegularFile to check), then simply call addNewZipEntry.
5.3. If source is a directory (use Files.isDirectory to check), then:
5.3.1. Create a FileManager object, passing source to the constructor
5.3.2. Get a list of files from the file manager, and save them to the fileNames variable
5.3.3. Call addNewZipEntry(zipOutputStream, source, fileName) for each element of fileNames.
5.4. If source isn't a folder or a file, throw a PathNotFoundException.

Requirements:

Add a private void addNewZipEntry(ZipOutputStream zipOutputStream, Path filePath, Path fileName) throws Exception method to the ZipFileManager class.
The addNewZipEntry method must be implemented according to the task conditions.
Replace part of the createZip method's code with a call to the addNewZipEntry method.
Add a private void copyData(InputStream in, OutputStream out) throws Exception method to the ZipFileManager class.
The copyData method must read data from "in" and write to "out" until it reads all of the bytes.
Replace part of the addNewZipEntry method's code with a call to the new copyData method.
The createZip method in the ZipFileManager class must be completed according to the task conditions.

package com.codegym.task.task31.task3110; import com.codegym.task.task31.task3110.command.ExitCommand; import com.codegym.task.task31.task3110.exception.NoSuchZipFileException; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.nio.file.Paths; public class Archiver { public static void main(String[] args) throws IOException { // String archivePath; // String filePath; // ZipFileManager zipFileManager; Operation operation = null; do { try { operation = askOperation(); CommandExecutor.execute(operation); } catch (NoSuchZipFileException e) { ConsoleHelper.writeMessage("You didn't select an archive or you selected an invalid file."); } catch (Exception ex) { ConsoleHelper.writeMessage("An error occurred. Please check the entered data."); } } while (operation != Operation.EXIT); // try (BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(System.in))) { // System.out.print("Enter the full path to the archive: "); // archivePath = bufferedReader.readLine(); // // System.out.print("Enter the path to the file to be zipped: "); // filePath = bufferedReader.readLine(); // // zipFileManager = new ZipFileManager(Paths.get(archivePath)); // zipFileManager.createZip(Paths.get(filePath)); // // } catch (IOException e) { // e.printStackTrace(); // } catch (Exception ex) { // ex.printStackTrace(); // } // // ExitCommand exit = new ExitCommand(); // try { // exit.execute(); // } catch (Exception e) { e.printStackTrace(); } } public static Operation askOperation() throws IOException { ConsoleHelper.writeMessage("Select an operation:\n" + "0 - Zip files into an archive\n" + "1 - Add a file to an archive\n" + "2 - Remove a file from an archive\n" + "3 - Extract an archive\n" + "4 - View the contents of an archive\n" + "5 - Exit"); return Operation.values()[ConsoleHelper.readInt()]; } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Nobody

Level 37 , Seattle, US

23 June 2019, 17:51

solution

i used to have trouble with this task before. and problem actually not the addnewZip method. i'm not sure but you can try to mofify the copy method something like this: byte[] buff = new byte[1024]; int i = 0; while ((i = in.read(buff)) != -1){ out.write(buff, 0, i); } Because when you read zipstream. somehow i dont know but you will have extra data if you read it by bufferedreader like that

Andrew

Level 29 , Seattle, United States

23 June 2019, 20:17

Thanks so much. I'd sure like to figure out where I went wrong with the BufferedReader.