Please help me to figure my mistake out

Question about the task

Minesweeper (Part 6/16)

Games, Level 0, Lesson 0

Under discussion

Every time it's showing like "You are checking for the field that is a mine", even i tried by changing the conditions.

Now let's count the mines in adjacent cells. To do this, we'll add a field to each cell of the matrix, which will be responsible for the number of mined neighbors. First, we find all the neighbors, and then we count how many of them are mined.

To get the list of neighbors, you now have the getNeighbors() method, which has one GameObject (cell) parameter.

Your task is to, in a separate method, count the number of mined neighbors for each cell in gameField and assign this value to the appropriate field of the cell.

Although your work is not visible (you started program to see what happens, right?), it is very important to future steps.

Requirements:

The GameObject class must have a public int countMineNeighbors field.
The MinesweeperGame class must have a private void countMineNeighbors() method.
The countMineNeighbors() method should, for each non-mined cell in the gameField matrix, count the number of adjacent mined cells and assign this value to the countMineNeighbors field.
The countMineNeighbors() method should use the getNeighbors(GameObject gameObject) method.
In the createGame() method, after all the elements of the gameField matrix are created, the countMineNeighbors() method must be called.

package com.codegym.games.minesweeper; import com.codegym.engine.cell.*; public class MinesweeperGame extends Game{ private static final int SIDE=9; private GameObject[][] gameField = new GameObject[SIDE][SIDE]; private int countMinesOnField=0; public void initialize(){ setScreenSize(SIDE,SIDE); createGame(); } private void createGame(){ for(int i=0;i<SIDE;i++){ for(int j=0;j<SIDE;j++){ int n = getRandomNumber(10); if(n == 9){ gameField[j][i] = new GameObject(j,i,true); //setCellColor(j,i,Color.BLUE); countMinesOnField++; } else{ gameField[j][i] = new GameObject(j,i,false); setCellColor(j,i,Color.BLUE); } } } countMineNeighbors(); } private void countMineNeighbors(){ for(int i=0;i<SIDE;i++){ for(int j=0;j<SIDE;j++){ if(gameField[j][i].isMine==true){ getNeighbors(gameField[j][i]); } } } } public void getNeighbors(GameObject g){ int x = g.x; int y = g.y; int count = 0; if(x==0 && y==0){ if(gameField[x][y+1].isMine) count++; if(gameField[x+1][y].isMine) count++; if(gameField[x+1][y+1].isMine) count++; } if(x==0 && y==SIDE-1){ if(gameField[x][y-1].isMine) count++; if(gameField[x+1][y].isMine) count++; if(gameField[x+1][y-1].isMine) count++; } if(x==SIDE-1 && y==0){ if(gameField[x-1][y].isMine) count++; if(gameField[x][y+1].isMine) count++; if(gameField[x-1][y+1].isMine) count++; } if(x==SIDE-1 && y==SIDE-1){ if(gameField[x][y-1].isMine) count++; if(gameField[x-1][y].isMine) count++; if(gameField[x-1][y-1].isMine) count++; } if(x==0 && y!=0){ if(gameField[x][y+1].isMine) count++; if(gameField[x+1][y+1].isMine) count++; if(gameField[x+1][y].isMine) count++; if(gameField[x+1][y-1].isMine) count++; if(gameField[x][y-1].isMine) count++; } if(x!=0 && y==0 && y!=SIDE-1){ if(gameField[x-1][y].isMine) count++; if(gameField[x-1][y+1].isMine) count++; if(gameField[x][y+1].isMine) count++; if(gameField[x+1][y+1].isMine) count++; if(gameField[x+1][y+1].isMine) count++; } if(x==SIDE-1 && y!=0 && y!=SIDE-1){ if(gameField[x][y-1].isMine) count++; if(gameField[x-1][y-1].isMine) count++; if(gameField[x-1][y].isMine) count++; if(gameField[x-1][y+1].isMine) count++; if(gameField[x][y+1].isMine) count++; } if(x!=0 && x!=SIDE-1 && y==SIDE-1){ if(gameField[x-1][y].isMine) count++; if(gameField[x-1][y-1].isMine) count++; if(gameField[x][y-1].isMine) count++; if(gameField[x+1][y-1].isMine) count++; if(gameField[x][y+1].isMine) count++; if(gameField[x+1][y].isMine) count++; } if(x!=0 && y!=0 && x!=SIDE-1 && y!=SIDE-1){ if(gameField[x-1][y+1].isMine) count++; if(gameField[x][y+1].isMine) count++; if(gameField[x+1][y+1].isMine) count++; if(gameField[x+1][y].isMine) count++; if(gameField[x+1][y-1].isMine) count++; if(gameField[x][y-1].isMine) count++; if(gameField[x-1][y-1].isMine) count++; if(gameField[x-1][y].isMine) count++; } g.countMineNeighbors = count; } }

Comments (1)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

27 November 2019, 16:21

Line 38 is counting the neighbors only for mined cells. The task says it should do this for non-mined cells The CreateGame method you are mixing up array access with x,y coordinates. Each line that says gameField[][] should be i,j and not j,i. For example, line 20 it should be:

gameField[i][j] = new GameObject(j,i,true);

You can rewrite the CreateGame method to be more efficient:

private void createGame(){
   for(int i=0;i<SIDE;i++){
      for(int j=0;j<SIDE;j++) {
         boolean bomb = false;
         if (getRandomNumber(10) == 9) {
            bomb = true;
            countMinesOnField++;
         }

         gameField[i][j] = new GameObject(j, i, bomb);
         setCellColor(j, i, Color.BLUE);
      }
   }
   countMineNeighbors();
}