error on requirements 3 and 4

Question about the task

Archived

hello. i cant get around of what i'm doing wrong. i ran the program just fine, it gives the longest string, it shows all the longest strings, yet the last 2 conditions come false. any help is appreciated.

1. Initialize the list of strings.
2. Read 5 strings from the keyboard and add them to this list.
3. Using a loop, find the longest string in the list.
4. Display the string. If there is more than one, display each on a new line.

Requirements:

In the main method, initialize the Solution class's existing strings field to a new ArrayList<>.
The program should read 5 strings from the keyboard and write them to the list of strings.
The program should display the longest string.
If several strings qualify as the longest, then you need to display each of them on a new line.

package com.codegym.task.task07.task0708; import java.io.BufferedReader; import java.io.InputStreamReader; import java.util.ArrayList; import java.util.List; import java.util.Scanner; /* Longest string */ public class Solution { private static ArrayList <String> strings = new ArrayList<String>(); public static void main(String[] args) throws Exception { Scanner scanner = new Scanner(System.in); for (int i = 0; i <5; i++) { strings.add(scanner.nextLine()); } int length = 0; for (int i = 0; i < strings.size(); i++) { if (strings.get(i).length() > length) length = strings.get(i).length(); } for (int i = 0; i < strings.size(); i++) { if (strings.get(i).length() == length) System.out.println(strings.get(i)); } } }

Comments (7)

Popular
New
Old

You must be signed in to leave a comment

Dmitriy Bursa

Level 27 , Kyiv, Ukraine

2 August 2019, 17:51

try first declare array

private static List<String> strings;

and in the 'main' method initialize

strings = new ArrayList<String>();

AndreiJ Java Developer

2 August 2019, 22:17

that did the trick :) thank you! still don't get why though

Борис Славков

Level 9 , Sofia, Bulgaria

2 August 2019, 09:44

You need to clear the list before adding strings in it : )

AndreiJ Java Developer

2 August 2019, 16:37

what do you mean?

Борис Славков

Level 9 , Sofia, Bulgaria

5 August 2019, 09:39

list.clear() , in this case strings.clear(); You need to do this, because you don't know what is in the list before you use it (fill it with strings). It's the same as "strings = new ArrayList<String>();"

Dmitriy Bursa

Level 27 , Kyiv, Ukraine

31 July 2019, 19:32

I was initialize length as length of the 1st element (index=0) and in the loop was use exact value 5

for (int i = 1; i < 5; i++) //for get max length
for (int i = 0; i < 5; i++){ //for display

and try reverse compare

length < strings.get(i).length()

and I avoid naming variables as name of methods. :)

AndreiJ Java Developer

2 August 2019, 16:37

sill the same result :( this is so frustrating! I tried with your suggestions for (int i = 0; i <5; i++) { strings.add(scanner.nextLine()); } int length = strings.get(0).length(); for (int i = 1; i < strings.size(); i++) { if (length < strings.get(i).length()) length = strings.get(i).length(); } for (int i = 0; i < strings.size(); i++) { if (strings.get(i).length() == length) System.out.println(strings.get(i)); }