Whats wrong with my code pls!!!

Question about the task

Shortest or longest

Java Syntax, Level 7, Lesson 6

Resolved

My program seems to run correctly, but it is not satisfying the conditions. Help needed!

1. Create a list of strings.
2. Add 10 strings from the keyboard.
3. Find out which string occurs earlier in the list: the shortest or the longest.
If several strings are shortest or longest, then consider the very first such string encountered.
4. Display the string described in Step 3. One string should be displayed.

Requirements:

Declare a string list variable and immediately initialize it.
The program should read 10 strings from the keyboard and add them to the list.
The program should display the shortest string if it comes before the longest.
The program should display the longest string if it comes before the shortest.

package com.codegym.task.task07.task0712; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.ArrayList; /* Shortest or longest */ public class Solution { public static void main(String[] args) throws Exception { //write your code here ArrayList<String> list = new ArrayList<String>(); String s; int sshort=0; int sLong = 0; int indexs = 0; int indexl = 0; String shorts = null; String slongs = null; BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); for (int i = 0; i < 10; i++) { s = reader.readLine(); list.add(s); } sshort = list.get(0).length(); for (int i = 0; i < 10; i++) { if(sLong < list.get(i).length()) sLong = list.get(i).length(); if (sshort < list.get(i).length()) sshort = sshort; else sshort = list.get(i).length(); } System.out.println(sshort); System.out.println(sLong); for(int i = 0; i<10; i++){ if(sshort == list.get(i).length()) shorts = list.get(i); indexs = i; break; } for(int i = 0; i<10; i++){ if(sLong == list.get(i).length()){ slongs = list.get(i); indexl = i; break; } } if (indexs < indexl) System.out.println(shorts); else System.out.println(slongs); } }

Comments (1)

Popular
New
Old

You must be signed in to leave a comment

Anonymous #10410173 Full Stack Developer

22 August 2019, 15:18

solution

i hope this will help you

package com.codegym.task.task07.task0712;

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStreamReader;
import java.util.ArrayList;
import java.util.Scanner;

/*
Shortest or longest

*/

public class Solution {
    public static void main(String[] args) throws Exception {
        //write your code here
        Scanner sc = new Scanner(System.in);
        ArrayList<String> list = new ArrayList<String>();
        for(int i = 0; i < 10; i++){
            String s= sc.nextLine();
            list.add(s);
        }

        //longest
        String lon = list.get(0);
        for(int i = 1; i < 5; i++)
        {
            String s = list.get(i);
            if( s.length() > lon.length() ) lon = list.get(i);
        }

        //Shortest
        String sho = list.get(0);
        for(int i = 1; i < 5; i++)
        {
            String s = list.get(i);
            if( s.length() < sho.length() ) sho = list.get(i);
        }

        for(int i = 0; i < list.size(); i++)
        {
            if(list.get(i).length() == sho.length())
            {
                System.out.println(list.get(i));
                break;
            }

            else if(list.get(i).length() == lon.length())
            {
                System.out.println(list.get(i));
                break;
            }
    }
}
}